[Opendnssec-user] ods 1.3b0 logging

[Matthijs Mekking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Miek,

Looking at the code (src/adapter/adfile.c), there should be an error log:

"ods-signerd: [adapter] unable to read file: ...."

But I agree, perhaps here can be another log message.

Best regards,

Matthijs

On 04/19/2011 11:14 AM, Miek Gieben wrote:
> Hello,
> 
> I'm testing ods 1.3 and I'm encountering the following error when I
> try to sign a large zone:
> 
> Apr 19 10:46:54 signertest ods-signerd: [tools] rollback updates for zone nl
> 
> Looking in the code (src/signer/tools.c):
> 
>  97     start = time(NULL);
>  98     status = adapter_read(zone);
>  99     if (status == ODS_STATUS_OK) {
> 100         tmpname = ods_build_path(zone->name, ".inbound", 0);
> 101         status = ods_file_copy(zone->adinbound->configstr, tmpname);
> 102         free((void*)tmpname);
> 103         tmpname = NULL;
> 104     }
> 105 
> 106     if (status == ODS_STATUS_OK) {
> 107         ods_log_verbose("[%s] commit updates for zone %s", tools_str,
> 108                 zone->name?zone->name:"(null)");
> 109         status = zonedata_commit(zone->zonedata);
> 110     } else {
> 111         ods_log_warning("[%s] rollback updates for zone %s", tools_str,
> 112                 zone->name?zone->name:"(null)");
> 113         zonedata_rollback(zone->zonedata);
> 114     }
> 115     end = time(NULL);
> 
> Now either 'status = adapter_read(zone)' has failed, or 
> 'status = ods_file_copy(zone->adinbound->configstr, tmpname)', but I 
> can not determine which from the logging alone. It would help to also
> log errors if adapter_read() fails.
> 
> Kind regards,
> 
> --
>  Miek Gieben
>  Technical Advisor SIDN
> _______________________________________________
> Opendnssec-user mailing list
> Opendnssec-user at lists.opendnssec.org
> https://lists.opendnssec.org/mailman/listinfo/opendnssec-user
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNrV7mAAoJEA8yVCPsQCW5IY4H/21s6HiMArQf8jhHf5Yb/ChX
j/+Osn3bWafdiFRlHnMn0jqKl65Qy93FnNPcMcauwwLZNYFMMamnJZwKr2avloDU
q+EFfa908t6JqkejqQJbPALxu4oxLtXCDscW1ScX53w0WdvkCRJz1gbBGZGHaSqt
ZEfQHt0wItLYepPeTF6wuLzNYVcplDY1t+sneZKhVSqNcZO+i+SEgJgGs0N9H+pK
SJJ++Ipa1fY+BYtPxye9/M4GO2x7LDndH0IhrcZLjZvdFD6I3CP6otOcr+DX5Cb3
C3Cjb385YfIcbIlhk70HVveuev1/V1cz5ZFcTKEWP+yQZHfPEZCeNq44zT1g4eo=
=3hMC
-----END PGP SIGNATURE-----