[Opendnssec-user] ods 1.3b0 logging

[Miek Gieben]

Hello,

I'm testing ods 1.3 and I'm encountering the following error when I
try to sign a large zone:

Apr 19 10:46:54 signertest ods-signerd: [tools] rollback updates for zone nl

Looking in the code (src/signer/tools.c):

 97     start = time(NULL);
 98     status = adapter_read(zone);
 99     if (status == ODS_STATUS_OK) {
100         tmpname = ods_build_path(zone->name, ".inbound", 0);
101         status = ods_file_copy(zone->adinbound->configstr, tmpname);
102         free((void*)tmpname);
103         tmpname = NULL;
104     }
105 
106     if (status == ODS_STATUS_OK) {
107         ods_log_verbose("[%s] commit updates for zone %s", tools_str,
108                 zone->name?zone->name:"(null)");
109         status = zonedata_commit(zone->zonedata);
110     } else {
111         ods_log_warning("[%s] rollback updates for zone %s", tools_str,
112                 zone->name?zone->name:"(null)");
113         zonedata_rollback(zone->zonedata);
114     }
115     end = time(NULL);

Now either 'status = adapter_read(zone)' has failed, or 
'status = ods_file_copy(zone->adinbound->configstr, tmpname)', but I 
can not determine which from the logging alone. It would help to also
log errors if adapter_read() fails.

Kind regards,

--
 Miek Gieben
 Technical Advisor SIDN