[Opendnssec-user] Problems adding largish # of zones

[Yuri Schaeffer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Havard,

Admittedly I have not looked very good to this patch, I'm in my 'quiet
weeks'. But I do have my doubts about it. I think, from the top of my
head xfrd_tcp_release() is called for every TCP connection that it
tried to open. Regardless of success. Thus, if fd == -1, tcp_count
should still be decreased. -- Or did you see tcp_count wrap around zero?

//Yuri

On 23-12-15 01:02, Havard Eidnes wrote:
> Hi,
> 
> I've modified the diff to xfrd_tcp_release() so that it doesn't 
> decrease the available TCP sessions if the FD passed was already 
> -1, as can happen e.g. if you exceed the number of allowable open 
> FDs (bouncing into that is an error in itself, but this appears to
> help ... somewhat):
> 
> if (set->tcp_conn[conn]->fd != -1) { 
> close(set->tcp_conn[conn]->fd); +        set->tcp_count --; +    }
> else { +       ods_log_error("[%s] zone %s no FD to release towards
> %s", xfrd_str, +               zone->name, xfrd->master->address); 
> +       return; } set->tcp_conn[conn]->fd = -1; -    set->tcp_count
> --; -    return; +    ods_log_info("[%s] releasing TCP connection,
> active: %d", +               xfrd_str, set->tcp_count); +
> 
> Regards,
> 
> - Håvard
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlZ6kRcACgkQI3PTR4mhavjiZQCgtrp1VnN3XjsaQBlv7+yFXrBv
G8AAn1dnwJN5d2jUnMu7oLihaWy/KyLS
=I750
-----END PGP SIGNATURE-----
_______________________________________________
Opendnssec-user mailing list
Opendnssec-user at lists.opendnssec.org
https://lists.opendnssec.org/mailman/listinfo/opendnssec-user