[Opendnssec-user] ods-signer taking a very long time to complete

[Paul Wouters]

I've been trying to figure out why at times, sending an "ods-signer
sign zonename" command seems to just hang there for extremely long
times. I can see why the ods-signerd takes some time, but just sending
the command over the socket should not stall for like 20+ minutes, it
should take at most a few seconds.

Attaching gdb, I see:

(gdb) bt
#0  0x00000030dd40b75b in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x0000000000417d56 in ods_thread_wait (cond=0x146e508, lock=0x146e538, wait=3600) at shared/locks.c:135
#2  0x000000000040da85 in engine_run (engine=0x146e480, single_run=0) at daemon/engine.c:654
#3  0x000000000040f0fa in engine_start (cfgfile=<value optimized out>, cmdline_verbosity=<value optimized out>, daemonize=<value optimized out>, info=0, single_run=0) at daemon/engine.c:1022
#4  0x0000000000405f97 in main (argc=<value optimized out>, argv=<value optimized out>) at ods-signerd.c:165

Which leads to:

        lock_basic_lock(&engine->signal_lock);
         if (engine->signal == SIGNAL_RUN && !single_run) {
            ods_log_debug("[%s] taking a break", engine_str);
            lock_basic_sleep(&engine->signal_cond, &engine->signal_lock, 3600);
         }
         lock_basic_unlock(&engine->signal_lock);

I'm a little worried here about locks that just last 1h. If handling
things "every hour since startup" then timings between different two signers
can be of by quite a time. Would it perhaps make sense to make this 3600
a configurable item so we can have ods-signerd check more frequently to
see if there is work to be done?

Additionally, I would expect that ods-signer would wake up ods-signerd
out of whatever lock it has to do "immediate work", but looking at our
ods-signer command taking longer then 20 minutes, I'm not sure if this
is guaranteed to happen, and it might be that ods-signer is waiting for
"time since started modulo 3600" before it can deliver its command to
the daemon.

Paul