[Opendnssec-develop] Re: libhsm: parts renamed during 2.0 work

[Matthijs Mekking]

On 05/20/2014 03:15 PM, Jerry Lundström wrote:
> Hi Rick,
> 
> On tis, 2014-05-20 at 15:11 +0200, Rick van Rein wrote:
>>> So parts of libhsm has been renamed during the work with 2.0 since it
>>> was colliding name space wise with the new database objects.
>>
>> It has only been done for the clashing names?
> 
> Yes, because I just had to get it working and put the discussion (this
> one) further down the line.
> 
>> But that means that some identifiers start with hsm_ and others with libhsm_ — that is confusing.
> 
> I know and I would like to change all.
> 
>>> The commit is here:
>>> https://github.com/jelu/opendnssec/commit/194f02c7d65d16d91ffae964e5d6d00ef6722420
>>
>> I would suggest either applying the patch to all libhsm identifiers or, as Matthijs also requested, do this to the database backend.
> 
> No Matthijs suggested to change the database object name. I want to
> change the libhsm names.

I am fine with prepending everything libhsm_ too. Just I would like to
see the consistent prepending remain: Currently all libhsm calls are
prepended with hsm_. Your change makes an inconsistent prepending.


> 
>> Please note that I am not planning to move the patches to the 2.0 product — that is probably too far off to permit proper testing by me.
> 
> Ok, then you do not have to worry about this :)
> 
> 
> 
> _______________________________________________
> Opendnssec-develop mailing list
> Opendnssec-develop at lists.opendnssec.org
> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop
>