[Opendnssec-develop] [OpenDNSSEC] #221: Segmentation Fault on schedule.c:232

[OpenDNSSEC]

#221: Segmentation Fault on schedule.c:232
-----------------------------------------------------+----------------------
Reporter:  Sebastian Castro <sebastian@…>            |       Owner:  matthijs
    Type:  defect                                    |      Status:  new     
Priority:  trivial                                   |   Component:  Signer  
 Version:  trunk                                     |    Keywords:          
-----------------------------------------------------+----------------------
 When running OpenDNSSEC 1.3.0-trunk (r4624), I got a SEGFAULT.
 The problem is here:
     del_node = ldns_rbtree_delete(schedule->tasks, (const void*) task);
     if (del_node) {
         del_task = (task_type*) del_node->data;
         free((void*)del_node);
     } else {
         ods_log_warning(...);
     }
     if (del_task->flush) {

 If for some reason del_node returns NULL, del_task will be NULL as well,
 so del_task->flush will cause a SIGFAULT (which is my case). I saw the
 warning before ods-signerd crashed and I have the core dump as well. A
 workaround is to change the condition to
    if (del_task && del_task->flush)
 but I'm not sure if it breaks your logic.

-- 
Ticket URL: <http://trac.opendnssec.org/ticket/221>
OpenDNSSEC <http://www.opendnssec.org/>
OpenDNSSEC