[Opendnssec-develop] Hanging singer processes

[Rickard Bellgrim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi

Is this patch ok? So that we do not start the signer process if we do not get a serial.

Index: Zone.py
===================================================================
- --- Zone.py     (revision 2574)
+++ Zone.py     (working copy)
@@ -758,6 +758,11 @@
             cmd.append("-l")
             cmd.append(self.engine_config.syslog_facility_string)

+        soa_serial = self.find_serial()
+        if self.zone_config.soa_serial:
+            if soa_serial == None:
+                return False;
+
         sign_p = Util.run_tool(cmd)
         if not sign_p:
             if not self.last_signed:
@@ -771,13 +776,9 @@
         Util.write_p(sign_p, self.zone_config.soa_minimum,
                      ":soa_minimum ")
         if self.zone_config.soa_serial:
- -            soa_serial = self.find_serial()
- -            if not soa_serial == None:
- -                syslog.syslog(syslog.LOG_DEBUG,
- -                              "set serial to " + str(soa_serial))
- -                Util.write_p(sign_p, str(soa_serial), ":soa_serial ")
- -            else:
- -                return False
+            syslog.syslog(syslog.LOG_DEBUG,
+                          "set serial to " + str(soa_serial))
+            Util.write_p(sign_p, str(soa_serial), ":soa_serial ")
             if self.zone_config.soa_serial == "keep":
                 Util.write_p(sign_p, "1", ":soa_serial_keep ")
         # nsec3 params

-----BEGIN PGP SIGNATURE-----
Version: 9.8.3 (Build 4028)
Charset: utf-8

wsBVAwUBSx9nz+CjgaNTdVjaAQg9rwf9HZ3KXD3X+XzuCEFgTcJQ+HZA1TBCqDhF
6rq0qAS/L6+tcqNW8y2Dz3XXdLrAZ1Cw7zDIwry9y8GIDpYsShq0C7x6V8+8ime9
E2xJeIICBK39QYW6IppzHVm/fDapa+2xBTefJCmzvzamsq92gChzcuD/aR0CKjWI
+WP8Dx1qt6whQmjF7CshuvqqWlesAoevBmiUBLWOv8QTSh46t+UUbYT4TnyDCXWL
mwokRqeeH9oYCybD8VvNlPRwfmcZuvb/3x9BZSrlnmeL6dM/twQzDPwE6aMjf+Ox
avox/HIFTXFQff2ZaN4a91HOy6O0n6xWr5F1lyhbkEMisiZM/iPCNw==
=7yMO
-----END PGP SIGNATURE-----


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opendnssec.org/pipermail/opendnssec-develop/attachments/20091209/d65a908c/attachment.htm>