<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from rtf -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<font face="Arial" size="2">
<div>-----BEGIN PGP SIGNED MESSAGE-----</div>
<div>Hash: SHA256</div>
<div> </div>
<div>Hi</div>
<div> </div>
<div>Is this patch ok? So that we do not start the signer process if we do not get a serial.</div>
<div> </div>
<div>Index: Zone.py</div>
<div>===================================================================</div>
<div>- --- Zone.py (revision 2574)</div>
<div>+++ Zone.py (working copy)</div>
<div>@@ -758,6 +758,11 @@</div>
<div> cmd.append("-l")</div>
<div> cmd.append(self.engine_config.syslog_facility_string)</div>
<div> </div>
<div>+ soa_serial = self.find_serial()</div>
<div>+ if self.zone_config.soa_serial:</div>
<div>+ if soa_serial == None:</div>
<div>+ return False;</div>
<div>+</div>
<div> sign_p = Util.run_tool(cmd)</div>
<div> if not sign_p:</div>
<div> if not self.last_signed:</div>
<div>@@ -771,13 +776,9 @@</div>
<div> Util.write_p(sign_p, self.zone_config.soa_minimum,</div>
<div> ":soa_minimum ")</div>
<div> if self.zone_config.soa_serial:</div>
<div>- - soa_serial = self.find_serial()</div>
<div>- - if not soa_serial == None:</div>
<div>- - syslog.syslog(syslog.LOG_DEBUG,</div>
<div>- - "set serial to " + str(soa_serial))</div>
<div>- - Util.write_p(sign_p, str(soa_serial), ":soa_serial ")</div>
<div>- - else:</div>
<div>- - return False</div>
<div>+ syslog.syslog(syslog.LOG_DEBUG,</div>
<div>+ "set serial to " + str(soa_serial))</div>
<div>+ Util.write_p(sign_p, str(soa_serial), ":soa_serial ")</div>
<div> if self.zone_config.soa_serial == "keep":</div>
<div> Util.write_p(sign_p, "1", ":soa_serial_keep ")</div>
<div> # nsec3 params</div>
<div> </div>
<div>-----BEGIN PGP SIGNATURE-----</div>
<div>Version: 9.8.3 (Build 4028)</div>
<div>Charset: utf-8</div>
<div> </div>
<div>wsBVAwUBSx9nz+CjgaNTdVjaAQg9rwf9HZ3KXD3X+XzuCEFgTcJQ+HZA1TBCqDhF</div>
<div>6rq0qAS/L6+tcqNW8y2Dz3XXdLrAZ1Cw7zDIwry9y8GIDpYsShq0C7x6V8+8ime9</div>
<div>E2xJeIICBK39QYW6IppzHVm/fDapa+2xBTefJCmzvzamsq92gChzcuD/aR0CKjWI</div>
<div>+WP8Dx1qt6whQmjF7CshuvqqWlesAoevBmiUBLWOv8QTSh46t+UUbYT4TnyDCXWL</div>
<div>mwokRqeeH9oYCybD8VvNlPRwfmcZuvb/3x9BZSrlnmeL6dM/twQzDPwE6aMjf+Ox</div>
<div>avox/HIFTXFQff2ZaN4a91HOy6O0n6xWr5F1lyhbkEMisiZM/iPCNw==</div>
<div>=7yMO</div>
<div>-----END PGP SIGNATURE-----</div>
<div> </div>
<div> </div>
</font>
</body>
</html>