From jakob at kirei.se Tue Sep 9 06:24:27 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Tue, 9 Sep 2014 08:24:27 +0200 Subject: [Softhsm-develop] Re: [Opendnssec-develop] Release SoftHSM 2.0.0b1 In-Reply-To: References: Message-ID: <2876B107-A1AC-4836-887A-6E38B4A4C6C9@kirei.se> On 9 sep 2014, at 00:23, Rickard Bellgrim wrote: > All related issues have now been merged and closed. So I think we can progress the release of SoftHSM 2.0.0b1. Petr will contribute two more patches for AES key wrapping and PKCS OAEP, but that can be merged into e.g. b2. Good. Should I go ahead and tag & bag? jakob -- Jakob Schlyter Kirei AB - www.kirei.se From rickard at opendnssec.org Tue Sep 9 17:36:55 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Tue, 9 Sep 2014 19:36:55 +0200 Subject: [Softhsm-develop] Re: [Opendnssec-develop] Release SoftHSM 2.0.0b1 In-Reply-To: <2876B107-A1AC-4836-887A-6E38B4A4C6C9@kirei.se> References: <2876B107-A1AC-4836-887A-6E38B4A4C6C9@kirei.se> Message-ID: On Tue, Sep 9, 2014 at 8:24 AM, Jakob Schlyter wrote: > On 9 sep 2014, at 00:23, Rickard Bellgrim wrote: > > > All related issues have now been merged and closed. So I think we can > progress the release of SoftHSM 2.0.0b1. Petr will contribute two more > patches for AES key wrapping and PKCS OAEP, but that can be merged into > e.g. b2. > > Good. Should I go ahead and tag & bag? Yes, please! // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: From pspacek at redhat.com Wed Sep 24 12:20:46 2014 From: pspacek at redhat.com (Petr Spacek) Date: Wed, 24 Sep 2014 14:20:46 +0200 Subject: [Softhsm-develop] CK_RSA_PKCS_OAEP_PARAMS.source question Message-ID: <5422B71E.9050205@redhat.com> Hello, I'm working on a patch with PKCS #1 RSA OAEP support and I have a question regarding "source" member in CK_RSA_PKCS_OAEP_PARAMS structure. IMHO CK_RSA_PKCS_OAEP_PARAMS.source should always be set to CKZ_DATA_SPECIFIED, i.e. to 0x00000001. Is this correct (I'm looking into pkcs-11v2-30m1-d7.doc page 26)? I'm asking because current code ignores this value completely so I'm trying to determine if it is a bug or intentional decision. Thank you for clarification! -- Petr Spacek @ Red Hat From rickard at opendnssec.org Sun Sep 28 19:33:13 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Sun, 28 Sep 2014 21:33:13 +0200 Subject: [Softhsm-develop] CK_RSA_PKCS_OAEP_PARAMS.source question In-Reply-To: <5422B71E.9050205@redhat.com> References: <5422B71E.9050205@redhat.com> Message-ID: On Wed, Sep 24, 2014 at 2:20 PM, Petr Spacek wrote: > Hello, > > I'm working on a patch with PKCS #1 RSA OAEP support and I have a question > regarding "source" member in CK_RSA_PKCS_OAEP_PARAMS structure. > > IMHO CK_RSA_PKCS_OAEP_PARAMS.source should always be set to > CKZ_DATA_SPECIFIED, i.e. to 0x00000001. > > Is this correct (I'm looking into pkcs-11v2-30m1-d7.doc page 26)? > > I'm asking because current code ignores this value completely so I'm > trying to determine if it is a bug or intentional decision. > > Thank you for clarification! Yes, that is correct. I believe that this field was not checked because the parameter is not used by the function. If we want to be strict then source == CKZ_DATA_SPECIFIED, pSourceData == NULL_PTR, and ulSourceDataLen == 0 must be set. // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: