[Opendnssec-develop] Restructuring of lib.sh / functions-opendnssec.sh and a few changes to how things work

[Jerry Lundström]

Hi all,

I've done a bit of work on the test framework to try and get rid of
intermediate fails and it seems to have been successful.

The work has been done for 1.3, 1.4 and develop in these PR:
https://github.com/opendnssec/opendnssec/pull/54
https://github.com/opendnssec/opendnssec/pull/58
https://github.com/opendnssec/opendnssec/pull/61

Changes are for all branches:
- Added more checks to functions and made sure all variable are quoted
and local.
- Removed global syslog_grep_count_variable from
lib.sh/syslog_grep_count().
- Added syslog_grep_count2 and grep_this_count2 that echos the count.
- Used syslog_grep_count2 in Enforcer/Signer start/stop count functions
and added new global variable ODS_ENFORCER_START_COUNT /
ODS_ENFORCER_STOP_COUNT / ODS_SIGNER_START_COUNT /
ODS_SIGNER_STOP_COUNT.
- Added 2 new tool depend; pgrep and gsort/sort.
- Save test output in retries and failed tests
- Rewrote ods_enforcer_start_timeshift() based on log_this_timeout, it
starts Enforcer is the background and checks for output in syslog and if
there has not been any output for the given timeout it kills and fails.

Changes just for develop:
- Changed ods_reset_env() and ods_setup_env() to take the option -n in
case you want the Enforcer to not be stopped.

Short description of the changes to tests are:
- $syslog_grep_count_variable is gone, use (for ex)
$ODS_ENFORCER_START_COUNT instead.
- ods_start_enforcer_timeshift() does not need a timeout any more, it
works in a different and better way now.
- Timeout to ods_reset_env() has been removed for all test in develop
and I am currently testing to see where the Enforcer might need to live
a bit longer.

I am currently testing the develop branch and want to merge to ASAP so
please have a look and fire away some comments.

-- 
Jerry Lundström - OpenDNSSEC Developer
http://www.opendnssec.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: This is a digitally signed message part
URL: <http://lists.opendnssec.org/pipermail/opendnssec-develop/attachments/20140328/42519553/attachment.bin>