[Opendnssec-develop] Move to git

[Sara Dickinson]

On 12 Feb 2014, at 13:50, Jakob Schlyter <jakob at kirei.se> wrote:

> On 12 feb 2014, at 14:31, Sara Dickinson <sara at sinodun.com> wrote:
> 
>> Hmm… that is a big change we haven’t discussed before. How about I add an agenda item to the workshop for us to hammer out if/how we will do this once we all have a couple of weeks of git experience?
> 
> As a compromise until we have proper code review, can we at least state (in the pull request) that no review has been done nor is being requested?

Sounds reasonable. For a case of something like a lone typo/change to log message/truly trivial fix/regression test fix in a pull request then yes - the developer should spell this out in the pull request comment. Plus, the release manager has discretion to request a review in all cases before accepting anything! We will already be going from 1 to at least 2 pairs of eyes on every commit overnight :-)

> That would be like saying "I believe I'm invincible and I don't need no code review from anyone" :-)

Well - we all pretty much _think_ that anyway, don’t we?  In fact, that would make a good t-shirt ;-)
 
Sara.