[Opendnssec-develop] Move to git

[Sara Dickinson]

On 12 Feb 2014, at 11:56, Jakob Schlyter <jakob at kirei.se> wrote:

> On 12 feb 2014, at 12:53, Sara Dickinson <sara at sinodun.com> wrote:
> 
>> My point is that IMHO the role of the release manager is not to personally do a formal code review (requirements/design/implementation) of each pull request - that should be left to the developers - rather it is make sure the right people have reviewed it,  do a sanity check of the code and do the mechanics of running the tests/merge. Do people agree with this?
> 
> Yes, but the pull request must then contain a note from the reviewer IMHO.
> 

Absolutely, it should have a clear note from the developer if they want it reviewed before being accepted, and clear responses from reviewers. 

One thing I like about Crucible is that it lets you assign reviewer/moderator roles to people and then each one can easily indicate if they have accepted the review or not. I don’t see anything like this in the github review pages… 

I do see an ‘assignee’ field but I’m not sure if this could be used to assign a pull request to a reviewer who could then assign it back to the release manager when they are done? 

Sara.