From jerry at opendnssec.org Tue Feb 4 06:34:51 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 4 Feb 2014 07:34:51 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: <52EB9D81.6020306@nlnetlabs.nl> References: <52EB9D81.6020306@nlnetlabs.nl> Message-ID: On Fri, Jan 31, 2014 at 1:56 PM, Yuri Schaeffer wrote: > Some assertions: > - I should do all pull requests from my feature branch and keep it > around until it is successfully pulled. > Correct, you MUST keep the branch since its tied into the pull request. > - I should NOT do pull requests from my develop branch because requests > are on branches, not commits. > Correct, your develop branch will most likely be connected to the upstream develop branch and making changes to it will just create problems and more ugly merge messages. > - After I finish a feature branch. I can/should merge it in to my > develop branch. I need not wait for the commit to be in the remote > develop branch, because git can uniquely identify commits. > Even if it might work most times I do not recommend this, the order of commits in your develop branch might not be the same and that will create problems. > Now, the thing I'm fussy on is the need for rebasing. I think I get what > it does (it falsifies history by changing the time of branching?) but I > don't know why we need it. > It does not really falsify, its more that it takes all the commits made since the branching and replays them onto the branch again after updating it from the upstream. In this way you make sure that your commits still apply cleanly if you would do a pull request and avoid unnecessary merge messages. > An other observation. I expected opendnssec-workflow-test/develop to by > enforcerNG branch (current svn trunk), but it is not. The opendnssec-workflow-test repository is just a test convert of SVN, it is not correct but works for us to test GitHub. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Tue Feb 4 06:36:32 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 4 Feb 2014 07:36:32 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: References: Message-ID: On Thu, Jan 30, 2014 at 10:01 AM, Rickard Bellgrim wrote: > > On Thu, Jan 30, 2014 at 9:56 AM, Rickard Bellgrim wrote: > >> Hi >> >> https://wiki.opendnssec.org/display/OpenDNSSEC/Git >> >> >> I am getting those merge commits that you do not like, when following the >> instructions. How should you avoid them? >> > > Are you using this? > > git config --global branch.autosetuprebase always > No, I've not made any config. Where is the workflow/instructions are you getting merge commits? -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From rickard at opendnssec.org Tue Feb 4 08:13:21 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Tue, 4 Feb 2014 09:13:21 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: References: Message-ID: > > No, I've not made any config. > > Where is the workflow/instructions are you getting merge commits? > When I do "git merge upstream/develop develop": $ git branch -D gitignore Deleted branch gitignore (was 15e51fa). $ git push origin :gitignore To git at github.com:bellgrim/SoftHSMv1.git - [deleted] gitignore $ git fetch upstream remote: Counting objects: 4, done. remote: Compressing objects: 100% (4/4), done. remote: Total 4 (delta 0), reused 0 (delta 0) Unpacking objects: 100% (4/4), done. >From https://github.com/opendnssec/SoftHSMv1 * [new branch] develop -> upstream/develop * [new branch] master -> upstream/master $ git merge upstream/master master Already up-to-date. Yeeah! $ git merge upstream/develop develop Fast-forwarding to: upstream/develop Already up-to-date with develop Merge made by the 'octopus' strategy. .gitignore | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 .gitignore $ git log commit a64ee8215df6c0b8839a826df2d7a4c4f81971b3 Author: Rickard Bellgrim Date: Tue Feb 4 09:06:43 2014 +0100 Merge branch 'develop', remote-tracking branch 'upstream/develop' into devel $ git push --all Counting objects: 6, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 890 bytes, done. Total 5 (delta 2), reused 0 (delta 0) To git at github.com:bellgrim/SoftHSMv1.git 050e4e8..a64ee82 develop -> develop -------------- next part -------------- An HTML attachment was scrubbed... URL: From yuri at nlnetlabs.nl Tue Feb 4 08:45:47 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Tue, 04 Feb 2014 09:45:47 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> Message-ID: <52F0A8BB.30306@nlnetlabs.nl> On 04-02-14 07:34, Jerry Lundstr?m wrote: >> - After I finish a feature branch. I can/should merge it in to my >> develop branch. I need not wait for the commit to be in the remote >> develop branch, because git can uniquely identify commits. > Even if it might work most times I do not recommend this, the order of > commits in your develop branch might not be the same and that will > create problems. Okay, what would you say is the recommended workflow when I want to develop the next feature/fix? Of course this new feature depends on the still pending pull of the previous feature. -- Composed on an actual keyboard: all typos genuine. From jerry at opendnssec.org Tue Feb 4 09:12:45 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 4 Feb 2014 10:12:45 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> Message-ID: <6600034756208105568@unknownmsgid> > On 4 feb 2014, at 09:45, Yuri Schaeffer wrote: > > Okay, what would you say is the recommended workflow when I want to > develop the next feature/fix? Of course this new feature depends on the > still pending pull of the previous feature. If the fix is so heavily depended on this new feature it should have been included into the pull request. If it is a new feature depended on this feature it might also be included in the same pull request. But if the feature in the pull request is a "should we do it like this" then you need to wait for it to be accepted before starting development on a new feature that uses that feature. Pull requests does not have to be small changes, they should rather be large changes. For example, if you develop a new feature (1) you might make changes to core functions (2) and make a test (3) for the new feature. That is not 3 pull requests but rather just one where all of this is fixed. If more then one developer is given a new feature that requires both to make changes to the same branch then this can be resolved by giving out accesa to your own branch or we can setup a collabiration repository where these branches can be made that all have access to. Hope its a bit clearer. /Jerry From jerry at opendnssec.org Tue Feb 4 09:47:49 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 4 Feb 2014 10:47:49 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: Message-ID: <88CB91C6-4D2C-4FB7-8124-1E9241F922E0@opendnssec.org> On 04 Feb 2014, at 09:13 , Rickard Bellgrim wrote: > When I do "git merge upstream/develop develop": I?ve tested some my self now and I can?t replicate what you got. So I can only conclude that you have an unclean fork where the commit history differs from the upstream. You should delete your fork and refork. I will change the documentation some and add ?ff-only for the merge since it should always only fast forward the changes (which does not add a merge message) otherwise something is wrong. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From yuri at nlnetlabs.nl Tue Feb 4 09:48:25 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Tue, 04 Feb 2014 10:48:25 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: <6600034756208105568@unknownmsgid> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> Message-ID: <52F0B769.7060303@nlnetlabs.nl> > Pull requests does not have to be small changes, they should rather be > large changes. For example, if you develop a new feature (1) you might > make changes to core functions (2) and make a test (3) for the new > feature. That is not 3 pull requests but rather just one where all of > this is fixed. I'm having a hard time grasping this workflow. Especially since currently for enfNG I'm working on bug reports rather then large features. So I can't imagine commenting on jira "fixed in 3bd9b07bafe4c1cc65def0e5d80ebfcbf8ee7a4b, maybe in 2 weeks I do a pull request because I'm working on #ODS-xxx and it needs bugfree code too". I guess I'm not quite in the Git way of thinking yet? //Yuri -- Composed on an actual keyboard: all typos genuine. From jerry at opendnssec.org Tue Feb 4 10:24:23 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 4 Feb 2014 11:24:23 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <52F0B769.7060303@nlnetlabs.nl> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> Message-ID: On 04 Feb 2014, at 10:48 , Yuri Schaeffer wrote: > I'm having a hard time grasping this workflow. Especially since > currently for enfNG I'm working on bug reports rather then large > features. So I can't imagine commenting on jira "fixed in > 3bd9b07bafe4c1cc65def0e5d80ebfcbf8ee7a4b, maybe in 2 weeks I do a pull > request because I'm working on #ODS-xxx and it needs bugfree code too". I don?t see why you can?t make a branch for that bug fix, fix it and make a pull request for that and then continue with your feature (which is in a different branch ofc). -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From yuri at nlnetlabs.nl Tue Feb 4 10:39:08 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Tue, 04 Feb 2014 11:39:08 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> Message-ID: <52F0C34C.9040509@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > I don?t see why you can?t make a branch for that bug fix, fix it > and make a pull request for that and then continue with your > feature (which is in a different branch ofc). Yes but you advised me against merging the bug fix to my other branches (or just develop?). So how can I use 'feature' and 'bugfix' simultaneously? Imagine -for argument sake- the bugfix is for "ODS does not compile". My impression of Git was that each commit can be uniquely identified. Thus applying commits to multiple branches and then merging them does not cause conflicts [for those commits]. But that is not true? - -- Composed on an actual keyboard: all typos genuine. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlLww0wACgkQI3PTR4mhavg0agCgwZizvsACPtwJovJZKtIckUR9 rhsAoKn6jpZdv1o6saKnXcyyXftTbT0w =44t6 -----END PGP SIGNATURE----- From jerry at opendnssec.org Tue Feb 4 11:59:02 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 4 Feb 2014 12:59:02 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <52F0C34C.9040509@nlnetlabs.nl> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> Message-ID: On 04 Feb 2014, at 11:39 , Yuri Schaeffer wrote: > Yes but you advised me against merging the bug fix to my other > branches (or just develop?). So how can I use 'feature' and 'bugfix' > simultaneously? If the feature is depended on the changes made by bugfix you must either wait for it to be merged into upstream, then update your fork and rebase your feature or you can apply the same commits on your feature (in various ways) and later before making a pull request deal with the commits for the feature (also in various ways). There is no ?one way? to do things like this in git and you are free to do it in any way you want. All that matters in that the pull request you make in the end is clean. This will require you to know git very well and thats why I am advising against it in the beginning. > Imagine -for argument sake- the bugfix is for "ODS does not compile?. That is not a good example since that would never really be merged into the upstream since all pull requests are compiled and tested. > My impression of Git was that each commit can be uniquely identified. > Thus applying commits to multiple branches and then merging them does > not cause conflicts [for those commits]. But that is not true? It might work but it will most likely make the order in your tree wrong and you can get problems later on. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From yuri at nlnetlabs.nl Tue Feb 4 16:11:30 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Tue, 04 Feb 2014 17:11:30 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> Message-ID: <52F11132.20709@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> Imagine -for argument sake- the bugfix is for "ODS does not >> compile?. > That is not a good example since that would never really be merged > into the upstream since all pull requests are compiled and tested. Fine. what about: Imagine -for argument sake- the bugfix is for "ODS does not compile on computers with a pink keyboard?. >> My impression of Git was that each commit can be uniquely >> identified. Thus applying commits to multiple branches and then >> merging them does not cause conflicts [for those commits]. But >> that is not true? > It might work but it will most likely make the order in your tree > wrong and you can get problems later on. ack. - -- Composed on an actual keyboard: all typos genuine. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlLxETIACgkQI3PTR4mhavhtIACgsDLrkwd246+7iU5MXe85mKts 1mwAn05/pJONRPGZEz/+rsbgbThiG/Tv =G6Ot -----END PGP SIGNATURE----- From jerry at opendnssec.org Wed Feb 5 11:07:48 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 5 Feb 2014 12:07:48 +0100 Subject: [Opendnssec-develop] Reinstallation of testing platforms about to begin... Message-ID: Hi all, The reinstallation of the test platforms will begin tomorrow and will be done by before monday next week. Not all platforms will be reinstalled, these are the changes: debian64-ods01 => ubuntu10-ods01 ubuntu64-ods02 => ubuntu12-ods02 sl64-ods04 => redhat6-ods04 freebsd64-ods06 => suse11-ods06 solaris-ods07 => freebsd9-ods07 redhat64-ods08 => freebsd10-ods08 netbsd64-ods09 => solaris11-x86-ods09 These platforms will be removed from all jobs on Jenkins and then later added when the platform is up. Other platforms are not touched or disabled so Jenkins will work as normal for all other nodes. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Wed Feb 5 11:33:23 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 5 Feb 2014 11:33:23 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: <52F11132.20709@nlnetlabs.nl> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> Message-ID: <67BAAF0A-F449-4AA5-9814-65C132BF477B@sinodun.com> Hi, Late to the party here, but I think I see where Yuri is coming from. If I understand the workflow correctly, the strict recommendation is that everything from a large feature to a 1 line bug fix should be done on its own feature branch, which requires creating a new branch, building it and then processing a separate pull request (with all the associated overhead). And if these fixes are ones that need porting to other releases then I need a separate feature branch per bug per release. Of course, you could in theory batch several bug fixes into one pull request (if they are for the same branch), but that then means they all have to wait for the whole batch to completed, reviewed and accepted. So maybe some common sense about what to combine in a pull request is needed? For example, if someone else needs a bug fix quickly, then you have to create a separate feature branch but if you are working on a bunch of small fixes, maybe just create one feature branch, put all the fixes in that and then do the pull request. Jerry/Jakob - you are not going to reject pull requests that fix more than one JIRA issue are you? ;-) Also, if a fix is dependant on an earlier fix (say, fix D depends on fix A), then the developer has to wait for the pull request for A to be accepted before they can start on fix D (or if they have already started) being able to pull down those changes, rebase the feature branch, finish the work, push and create a pull request for D. If Jerry/Jakob are busy or the pull request needs to be reviewed by somebody who isn?t around today then the developer just has to wait. There is no nice shortcut here, right? Have I understood all this correctly? If so, then at first read this process feels like a very heavy overhead compared to what we do now with svn because a) there are lots more steps and lots more commands needed b) I need a work area for every pull request, rather than just one per branch c) there are additional dependancies on other people, none of whom work full time on ODS d) there is an additional lag in waiting for pull requests to be processed I can see the bigger picture benefits of git but this workflow doesn?t immediately seem to make developers daily lives any easier :-( ?.but then I am probably stuck in my svn ways?.Note to self: must drink the git kool-aid... Sara. On 4 Feb 2014, at 16:11, Yuri Schaeffer wrote: > Signed PGP part > >> Imagine -for argument sake- the bugfix is for "ODS does not > >> compile?. > > > That is not a good example since that would never really be merged > > into the upstream since all pull requests are compiled and tested. > > Fine. what about: > Imagine -for argument sake- the bugfix is for "ODS does not compile on > computers with a pink keyboard?. > > >> My impression of Git was that each commit can be uniquely > >> identified. Thus applying commits to multiple branches and then > >> merging them does not cause conflicts [for those commits]. But > >> that is not true? > > > It might work but it will most likely make the order in your tree > > wrong and you can get problems later on. > > ack. > > > -- > Composed on an actual keyboard: all typos genuine. > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop From jerry at opendnssec.org Wed Feb 5 11:44:56 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 5 Feb 2014 12:44:56 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <67BAAF0A-F449-4AA5-9814-65C132BF477B@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <67BAAF0A-F449-4AA5-9814-65C132BF477B@sinodun.com> Message-ID: <025F6D6B-9F9A-4A7A-B2CE-1B481275E8D9@opendnssec.org> On 05 Feb 2014, at 12:33 , Sara Dickinson wrote: > Of course, you could in theory batch several bug fixes into one pull request (if they are for the same branch), but that then means they all have to wait for the whole batch to completed, reviewed and accepted. So maybe some common sense about what to combine in a pull request is needed? For example, if someone else needs a bug fix quickly, then you have to create a separate feature branch but if you are working on a bunch of small fixes, maybe just create one feature branch, put all the fixes in that and then do the pull request. Jerry/Jakob - you are not going to reject pull requests that fix more than one JIRA issue are you? ;-) No why should we. If you do a pull request for many small bugfixes at the end of the day thats all fine, just remember to commit each fix for it self with the correct Jira tag. In this way just that fix will be related to the Jira issue and not all of them. It will also make it easier to see what has been done for what issue and to remove fault commits or just cherry pick a few. > Also, if a fix is dependant on an earlier fix (say, fix D depends on fix A), then the developer has to wait for the pull request for A to be accepted before they can start on fix D (or if they have already started) being able to pull down those changes, rebase the feature branch, finish the work, push and create a pull request for D. If Jerry/Jakob are busy or the pull request needs to be reviewed by somebody who isn?t around today then the developer just has to wait. There is no nice shortcut here, right? There are plenty BUT you need to know git and since people are just starting to work with git this is not something you start with. You really REALLY have to know how git works! All the ?if this? ?if that? are also many moment 22?s. I don?t think its wise to try and think of the worst situation here because most of them should not happen when this workflow is in place. You do not need to make a pull request to fix the broken code because it should not be broken in the first place thanks to this workflow and ALL the tests we do. But even if that happens it will be very rare occasions and very specific situations and that will be manageable. > Have I understood all this correctly? If so, then at first read this process feels like a very heavy overhead compared to what we do now with svn because > a) there are lots more steps and lots more commands needed > b) I need a work area for every pull request, rather than just one per branch > c) there are additional dependancies on other people, none of whom work full time on ODS > d) there is an additional lag in waiting for pull requests to be processed This is correct IF you want the code to the upstream! There is nothing stopping you from working with your fork just like you do in SVN now. > I can see the bigger picture benefits of git but this workflow doesn?t immediately seem to make developers daily lives any easier :-( > ?.but then I am probably stuck in my svn ways?.Note to self: must drink the git kool-aid... Best way to learn git is to use git and you really need to use it to understand it. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Wed Feb 5 12:15:44 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 5 Feb 2014 12:15:44 +0000 Subject: [Opendnssec-develop] Reinstallation of testing platforms about to begin... In-Reply-To: References: Message-ID: Hi Jerry, I did mention this in the team meeting, but you were not there?. As you know Yuri and I have been working on the 2.0.0a4 release, with the aim of getting it out by the end of this week. We have now virtually finished coding and I am about to start trying to turn on as many regression tests as possible and adding the mysql and daily jobs. It would be really nice to have all the platforms available while we do this. Could you delay this re-installation until we have at least done a first round of testing to determine if the release will go ahead this week? Can you please try to give more than 1 days notice when you re-install the rest? Thanks Sara. On 5 Feb 2014, at 11:07, Jerry Lundstr?m wrote: > Hi all, > > The reinstallation of the test platforms will begin tomorrow and will be done by before monday next week. > > Not all platforms will be reinstalled, these are the changes: > > debian64-ods01 => ubuntu10-ods01 > ubuntu64-ods02 => ubuntu12-ods02 > sl64-ods04 => redhat6-ods04 > freebsd64-ods06 => suse11-ods06 > solaris-ods07 => freebsd9-ods07 > redhat64-ods08 => freebsd10-ods08 > netbsd64-ods09 => solaris11-x86-ods09 > > These platforms will be removed from all jobs on Jenkins and then later added when the platform is up. Other platforms are not touched or disabled so Jenkins will work as normal for all other nodes. > > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop From jerry at opendnssec.org Wed Feb 5 12:18:10 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 5 Feb 2014 13:18:10 +0100 Subject: [Opendnssec-develop] Reinstallation of testing platforms about to begin... In-Reply-To: References: Message-ID: On 05 Feb 2014, at 13:15 , Sara Dickinson wrote: > It would be really nice to have all the platforms available while we do this. Could you delay this re-installation until we have at least done a first round of testing to determine if the release will go ahead this week? All other platforms will still be up and available for testing, this should not hinder any testing. You will still have plenty of platforms to test on, isn?t that enough? > Can you please try to give more than 1 days notice when you re-install the rest? The rest? The rest won?t be installed, we agreed on a new list of platforms and when they are set up ?the rest? will be removed. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Wed Feb 5 14:23:48 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 5 Feb 2014 15:23:48 +0100 Subject: [Opendnssec-develop] Reinstallation of testing platforms about to begin... In-Reply-To: References: Message-ID: On 05 Feb 2014, at 13:18 , Jerry Lundstr?m wrote: > All other platforms will still be up and available for testing, this should not hinder any testing. You will still have plenty of platforms to test on, isn?t that enough? Are these platforms not enough to test on for 1-2 days: centos32-ods13 freebsd32-ods15 openbsd64-ods10 opensuse32-ods14 opensuse64-ods05 solaris11-sparc64 suse64-ods11 ubuntu12-amd64-ods03 ubuntu32-ods12 -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Wed Feb 5 15:29:13 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 5 Feb 2014 16:29:13 +0100 Subject: [Opendnssec-develop] Re: Reinstallation of testing platforms about to begin... In-Reply-To: References: Message-ID: <992A43D4-7B6B-4691-A5C2-3CBC933EFE5C@opendnssec.org> List will be change somewhat to leave the current redhat machine intact since there has been changed made to it for 1.4 (bind and validns). debian64-ods01 => ubuntu10-ods01 ubuntu64-ods02 => ubuntu12-ods02 sl64-ods04 => redhat6-ods04 opensuse64-ods05 => suse11-ods05 freebsd64-ods06 => freebsd9-ods06 solaris-ods07 => freebsd10-ods07 netbsd64-ods09 => solaris11-x86-ods09 -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From matthijs at nlnetlabs.nl Thu Feb 6 07:03:47 2014 From: matthijs at nlnetlabs.nl (Matthijs Mekking) Date: Thu, 06 Feb 2014 08:03:47 +0100 Subject: [Opendnssec-develop] Fwd: Virtualization and HSM support In-Reply-To: <52F00523.50309@nzrs.net.nz> References: <52F00523.50309@nzrs.net.nz> Message-ID: <52F333D3.80208@nlnetlabs.nl> Anyone experience? -------- Original Message -------- Subject: Virtualization and HSM support Date: Tue, 04 Feb 2014 10:07:47 +1300 From: Sebastian Castro To: Patrik Wallstr?m , Matthijs Mekking Hi guys: During the OpenDNSSEC tutorial, I one of the attendants asked me if USB or PCI-based HSM worked well with virtualization, for example, to deploy an HSM to a host and run a bunch of virtual servers to provide the signing service to different "customers". Do you have any experience around that topic? Feel free to discuss the idea internally. Cheers, -- Sebastian Castro Technical Research Manager .nz Registry Services (New Zealand Domain Name Registry Limited) desk: +64 4 495 2337 mobile: +64 21 400535 From jerry at opendnssec.org Thu Feb 6 07:42:31 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 6 Feb 2014 08:42:31 +0100 Subject: [Opendnssec-develop] solaris11-sparc64 (former solaris-t2000-sparc64-ods16) removed from Jenkins jobs Message-ID: Hi, The sparc box was building for 1.3 and 1.4 (not -mysql) and although its successful it added A LOT of build and test time, some 1.5-3x the time is takes for the other platforms. This is mainly because of the sparc arch, a lot more "cpu's" but at much less speed and there is really no way for us to utilize the cpu's when testing. I have removed it from all jobs and we need to rework how all our testing is performed later on now with pull requests and when we do that we can decide in what phase this sparc box should be used. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From yuri at nlnetlabs.nl Thu Feb 6 09:48:48 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Thu, 06 Feb 2014 10:48:48 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <025F6D6B-9F9A-4A7A-B2CE-1B481275E8D9@opendnssec.org> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <67BAAF0A-F449-4AA5-9814-65C132BF477B@sinodun.com> <025F6D6B-9F9A-4A7A-B2CE-1B481275E8D9@opendnssec.org> Message-ID: <52F35A80.7060807@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > You do not need to make a pull request to fix the broken code > because it should not be broken in the first place thanks to this > workflow and ALL the tests we do. I admire your optimism. :) However you don't give me a choice other than to quote one of Murphy's laws: "If you make something idiot proof, someone will just invent a better idiot." > Best way to learn git is to use git and you really need to use it > to understand it. Yes I see that now. Would you say the following art describes our workflow accurate? develop ----> master ^ | ^ | | | ( upstream ) ________|___|___|________ | | | feat1 | feat2 ( origin ) ^ | ^ ____|_______|_______|____ | | | | V | ( local ) | develop | | | | | | V V | feat1 feat2 I.e. I need not maintain the develop branch in origin. And if I do I whould pull upstream to local and then push it to origin? (which might be a good idea when working on multiple machines) - -- Composed on an actual keyboard: all typos genuine. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlLzWn8ACgkQI3PTR4mhavjzDACeJTs3+gsWlb8vE/T5xwZuvupp ATEAoMOFDGnnbOrtHG89fr8vnIC7DkRV =qD8d -----END PGP SIGNATURE----- From yuri at nlnetlabs.nl Thu Feb 6 09:53:23 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Thu, 06 Feb 2014 10:53:23 +0100 Subject: [Opendnssec-develop] solaris11-sparc64 (former solaris-t2000-sparc64-ods16) removed from Jenkins jobs In-Reply-To: References: Message-ID: <52F35B93.1080508@nlnetlabs.nl> > I have removed it from all jobs and we need to rework how all our > testing is performed later on now with pull requests and when we do that > we can decide in what phase this sparc box should be used. If we put it in a job of its own, dependent on either the build or the test job, would that work? Or would it still hold up the rest of the tests to rerun? -- Composed on an actual keyboard: all typos genuine. From yuri at nlnetlabs.nl Thu Feb 6 10:04:09 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Thu, 06 Feb 2014 11:04:09 +0100 Subject: [Opendnssec-develop] Fwd: Virtualization and HSM support In-Reply-To: <52F333D3.80208@nlnetlabs.nl> References: <52F00523.50309@nzrs.net.nz> <52F333D3.80208@nlnetlabs.nl> Message-ID: <52F35E19.90007@nlnetlabs.nl> > During the OpenDNSSEC tutorial, I one of the attendants asked me if USB > or PCI-based HSM worked well with virtualization, for example, to deploy > an HSM to a host and run a bunch of virtual servers to provide the > signing service to different "customers". 2cts: Well, I always understood the PCI-passthrough is quite mature in for example XEN. You could even pass the USB controller. In virtualbox it is trivial to pass USB devices to the guest system. The up site to this is you can use the normal drivers in your guest OS. !BUT! It can only passed to 1 guest at a time. -- Composed on an actual keyboard: all typos genuine. From rickard at opendnssec.org Thu Feb 6 10:05:05 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Thu, 6 Feb 2014 11:05:05 +0100 Subject: [Opendnssec-develop] Fwd: Virtualization and HSM support In-Reply-To: <52F333D3.80208@nlnetlabs.nl> References: <52F00523.50309@nzrs.net.nz> <52F333D3.80208@nlnetlabs.nl> Message-ID: On Thu, Feb 6, 2014 at 8:03 AM, Matthijs Mekking wrote: > Anyone experience? Have not tried it, but there is PCIe/USB passthrough in e.g. VMware ESX. Do not how compatible that is. // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Thu Feb 6 10:06:30 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 6 Feb 2014 11:06:30 +0100 Subject: [Opendnssec-develop] solaris11-sparc64 (former solaris-t2000-sparc64-ods16) removed from Jenkins jobs In-Reply-To: <52F35B93.1080508@nlnetlabs.nl> References: <52F35B93.1080508@nlnetlabs.nl> Message-ID: <-1537271471994333613@unknownmsgid> On 6 feb 2014, at 10:53, Yuri Schaeffer wrote: If we put it in a job of its own, dependent on either the build or the test job, would that work? Or would it still hold up the rest of the tests to rerun? Its not about that and we cant run tests parallell. Its more about when (smoke|daily|weekly) we should use the sparc since its so slow and what we run today in each step. A new "build" today takes 15-25mins, not including sparc, to run the current jobs, a bit much if you throw in pull requests. Something to discuss later on. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jakob at kirei.se Thu Feb 6 10:08:11 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Thu, 6 Feb 2014 11:08:11 +0100 Subject: [Opendnssec-develop] Virtualization and HSM support In-Reply-To: <52F333D3.80208@nlnetlabs.nl> References: <52F00523.50309@nzrs.net.nz> <52F333D3.80208@nlnetlabs.nl> Message-ID: <5655D75B-4A70-403B-8BDD-8E451E18B1B1@kirei.se> On 6 feb 2014, at 08:03, Matthijs Mekking wrote: > During the OpenDNSSEC tutorial, I one of the attendants asked me if USB > or PCI-based HSM worked well with virtualization, for example, to deploy > an HSM to a host and run a bunch of virtual servers to provide the > signing service to different "customers". Do you have any experience > around that topic? Feel free to discuss the idea internally. Passthrough would only work for one virtual server at a time, so sharing would not be very useful. I would look into a PKCS#11 proxy [1] instead, basically creating your own networked HSM with a USB/PCI backend. However, the "customers" would need to trust each somewhat, as they actually share tokens within the same HSM. jakob [1] https://github.com/SUNET/pkcs11-proxy From jerry at opendnssec.org Thu Feb 6 10:29:30 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 6 Feb 2014 11:29:30 +0100 Subject: [Opendnssec-develop] Virtualization and HSM support In-Reply-To: <5655D75B-4A70-403B-8BDD-8E451E18B1B1@kirei.se> References: <52F00523.50309@nzrs.net.nz> <52F333D3.80208@nlnetlabs.nl> <5655D75B-4A70-403B-8BDD-8E451E18B1B1@kirei.se> Message-ID: <8874006324247524534@unknownmsgid> Maybe move this dicussion to the user list since replies from Sebastian will get stuck for approval and info might be useful for others? -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ On 6 feb 2014, at 11:08, Jakob Schlyter wrote: On 6 feb 2014, at 08:03, Matthijs Mekking wrote: During the OpenDNSSEC tutorial, I one of the attendants asked me if USB or PCI-based HSM worked well with virtualization, for example, to deploy an HSM to a host and run a bunch of virtual servers to provide the signing service to different "customers". Do you have any experience around that topic? Feel free to discuss the idea internally. Passthrough would only work for one virtual server at a time, so sharing would not be very useful. I would look into a PKCS#11 proxy [1] instead, basically creating your own networked HSM with a USB/PCI backend. However, the "customers" would need to trust each somewhat, as they actually share tokens within the same HSM. jakob [1] https://github.com/SUNET/pkcs11-proxy _______________________________________________ Opendnssec-develop mailing list Opendnssec-develop at lists.opendnssec.org https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Thu Feb 6 12:17:35 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 6 Feb 2014 13:17:35 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <52F35A80.7060807@nlnetlabs.nl> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <67BAAF0A-F449-4AA5-9814-65C132BF477B@sinodun.com> <025F6D6B-9F9A-4A7A-B2CE-1B481275E8D9@opendnssec.org> <52F35A80.7060807@nlnetlabs.nl> Message-ID: On 06 Feb 2014, at 10:48 , Yuri Schaeffer wrote: > Yes I see that now. Would you say the following art describes our > workflow accurate? > > develop ----> master > ^ | ^ > | | | ( upstream ) > ________|___|___|________ > | | | > feat1 | feat2 ( origin ) > ^ | ^ > ____|_______|_______|____ > | | | > | V | ( local ) > | develop | > | | | | > | V V | > feat1 feat2 > > I.e. I need not maintain the develop branch in origin. And if I do I > whould pull upstream to local and then push it to origin? (which might > be a good idea when working on multiple machines) Yes this would be better I think, need to change the documentation for it. You basically just use your fork for staging the pull request. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Thu Feb 6 14:12:07 2014 From: sara at sinodun.com (Sara Dickinson) Date: Thu, 6 Feb 2014 14:12:07 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: <52F11132.20709@nlnetlabs.nl> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> Message-ID: <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Hi, So, some other questions and comments: Workflow: - On the workflow wiki page, in the bullet point describing what to do when a pull request is accepted it says ?It is VERY IMPORTANT that you now DELETE YOUR USER REPOSITORY?. Shouldn?t this say ?It is VERY IMPORTANT that you now DELETE YOUR USER FEATURE BRANCH?? - I think we should add a note at this point in the instructions to say that if you want to use the feature branch to port the fix to a different release you need to keep it? - Also, am I right that the re-basing approach only works if you want to port _everything_ in that feature branch? So it if contains various fixes this isn?t the best way to port them? - If you do delete your feature branch, or need to cherry pick commits to port them then I imagine you use ?merge?? Jerry - could you please document this workflow too as I suspect this is going to be much more likely in practice than being able to do a clean rebase? - I presume it is good practice to update your fork and feature branch with changes from upstream right before doing a final test and creating a pull request? If so could we add that comment to the first bullet point this page? Pull requests: It is still not clear to me exactly what happens with the review stage or the tests. Jerry - I saw your email describing what build-bot commands are available, which look good. I see there is: "build - Build and run all tests? For ?build? when you say ?all tests? do you mean _all_ tests, or all the smoke tests? What about, to begin with we have build - Build build smoke_test - Build and run smoke tests build mod_test - Build and run smoke and modified tests build test - Build and run all tests I think have the first 3 as separate actions would give developers the most flexibility to run and fix builds/tests by themselves without having to involve anyone else? So I think we still need to decide what happens in a normal case on a pull request? a) I really like the idea that developers can create a pull request and initiate a build and run the smoke and/or modified tests before anyone else looks at the request. This sounds like the right thing to do in most cases. But if so, we should make sure our current smoke tests run in, say 5 or 10 mins max? b) Then who decides who should review it? - Seems sensible that the developer should requests a specific reviewer in the pull request comment if they want one? - If it doesn?t need a full blown review what happens - Jerry/Jakob will you give it the once over to see what you think? - If we want to give other developers who will be watching the pull requests time to comment how long should we wait before moving forward with the process? c) Then after this, what additional testing is done before the pull request is actually accepted? If we don?t run all the tests, then it is possible for the PR (see - I?m learning the lingo!) to be accepted and then break a test, but the tests take a long time. Is the initial plan to run all the existing tests on every pull request? Also, who is responsible for this stage - the developer or Jerry/Jakob? Sara. On 4 Feb 2014, at 16:11, Yuri Schaeffer wrote: > Signed PGP part > >> Imagine -for argument sake- the bugfix is for "ODS does not > >> compile?. > > > That is not a good example since that would never really be merged > > into the upstream since all pull requests are compiled and tested. > > Fine. what about: > Imagine -for argument sake- the bugfix is for "ODS does not compile on > computers with a pink keyboard?. > > >> My impression of Git was that each commit can be uniquely > >> identified. Thus applying commits to multiple branches and then > >> merging them does not cause conflicts [for those commits]. But > >> that is not true? > > > It might work but it will most likely make the order in your tree > > wrong and you can get problems later on. > > ack. > > > -- > Composed on an actual keyboard: all typos genuine. > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop From jerry at opendnssec.org Thu Feb 6 14:49:46 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 6 Feb 2014 15:49:46 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: On 06 Feb 2014, at 15:12 , Sara Dickinson wrote: > Workflow: > > - On the workflow wiki page, in the bullet point describing what to do when a pull request is accepted it says ?It is VERY IMPORTANT that you now DELETE YOUR USER REPOSITORY?. Shouldn?t this say ?It is VERY IMPORTANT that you now DELETE YOUR USER FEATURE BRANCH?? Fixed. > - I think we should add a note at this point in the instructions to say that if you want to use the feature branch to port the fix to a different release you need to keep it? You should only remove your feature branch after it has been merged and before that you should have made a copy of that feature branch to make pull request for another major version. If its already merged and you have removed your feature branch you can cherry pick the commits into a new feature branch and make a new pull request for a different major version. > - Also, am I right that the re-basing approach only works if you want to port _everything_ in that feature branch? So it if contains various fixes this isn?t the best way to port them? That is true. > - If you do delete your feature branch, or need to cherry pick commits to port them then I imagine you use ?merge?? Jerry - could you please document this workflow too as I suspect this is going to be much more likely in practice than being able to do a clean rebase? Ehm, no you don?t merge, you cherry-pick (yes its a actual git command). I can try and add some doc on that. > - I presume it is good practice to update your fork and feature branch with changes from upstream right before doing a final test and creating a pull request? If so could we add that comment to the first bullet point this page? Well yes and no, GitHub will tell you if the pull request will merge cleanly or not, if not then you need to update your feature branch with the changes made in the develop branch its based on and rebase and fix the conflicts. > Pull requests: > > It is still not clear to me exactly what happens with the review stage or the tests. Jerry - I saw your email describing what build-bot commands are available, which look good. I see there is: > "build - Build and run all tests? For ?build? when you say ?all tests? do you mean _all_ tests, or all the smoke tests? What about, to begin with we have > build - Build > build smoke_test - Build and run smoke tests > build mod_test - Build and run smoke and modified tests > build test - Build and run all tests > I think have the first 3 as separate actions would give developers the most flexibility to run and fix builds/tests by themselves without having to involve anyone else? We can add more later on but to begin we got ?build? now and it runs all tests, new and modified, which is just what happens now if you do a commit. > So I think we still need to decide what happens in a normal case on a pull request? > > a) I really like the idea that developers can create a pull request and initiate a build and run the smoke and/or modified tests before anyone else looks at the request. This sounds like the right thing to do in most cases. But if so, we should make sure our current smoke tests run in, say 5 or 10 mins max? This is what I?ve been saying many times now, we need to rework how and what we run at each stage. As low as possible is the goal. > b) Then who decides who should review it? > - Seems sensible that the developer should requests a specific reviewer in the pull request comment if they want one? > - If it doesn?t need a full blown review what happens - Jerry/Jakob will you give it the once over to see what you think? > - If we want to give other developers who will be watching the pull requests time to comment how long should we wait before moving forward with the process? Do we really need this in writing now? Think common sense here will prevail. > c) Then after this, what additional testing is done before the pull request is actually accepted? If we don?t run all the tests, then it is possible for the PR (see - I?m learning the lingo!) to be accepted and then break a test, but the tests take a long time. Is the initial plan to run all the existing tests on every pull request? Also, who is responsible for this stage - the developer or Jerry/Jakob? We can do both or just one, we can collectively decide per pull request based on the changes. The initial plan is to run all test because it was the easiest to get working at first (see ?build? above). -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Thu Feb 6 16:05:11 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 6 Feb 2014 17:05:11 +0100 Subject: [Opendnssec-develop] Re: Reinstallation of testing platforms about to begin... In-Reply-To: <992A43D4-7B6B-4691-A5C2-3CBC933EFE5C@opendnssec.org> References: <992A43D4-7B6B-4691-A5C2-3CBC933EFE5C@opendnssec.org> Message-ID: On 05 Feb 2014, at 16:29 , Jerry Lundstr?m wrote: > List will be change somewhat to leave the current redhat machine intact since there has been changed made to it for 1.4 (bind and validns). Validns has been added to dasbot so it will be available on all new platforms. > debian64-ods01 => ubuntu10-ods01 > ubuntu64-ods02 => ubuntu12-ods02 > freebsd64-ods06 => freebsd9-ods06 > solaris-ods07 => freebsd10-ods07 > netbsd64-ods09 => solaris11-x86-ods09 The above platforms and been reinstalled and all dependancy has been installed by dasbot. They will be added to Jenkins tomorrow. > sl64-ods04 => redhat6-ods04 > opensuse64-ods05 => suse11-ods05 These are left, SUSE needs more setup and dasbot magic and for the RedHat I need a new activation key (this might take time). All in all, reinstall/configure almost 7 different dists in under 4h! -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Fri Feb 7 07:56:44 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 08:56:44 +0100 Subject: [Opendnssec-develop] solaris11-sparc64 (former solaris-t2000-sparc64-ods16) removed from Jenkins jobs In-Reply-To: <-1537271471994333613@unknownmsgid> References: <52F35B93.1080508@nlnetlabs.nl> <-1537271471994333613@unknownmsgid> Message-ID: On Thu, Feb 6, 2014 at 11:06 AM, Jerry Lundstr?m wrote: > > Its not about that and we cant run tests parallell. Its more about when > (smoke|daily|weekly) we should use the sparc since its so slow and what we > run today in each step. A new "build" today takes 15-25mins, not including > sparc, to run the current jobs, a bit much if you throw in pull requests. > Hmm, we might even consider removing Solaris x86 from the often run tests. Our current smoke tests take 6-7 minutes on all Linux's but take 15+ mins on Solaris x86... -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From rickard at opendnssec.org Fri Feb 7 08:34:25 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Fri, 7 Feb 2014 09:34:25 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: > > I can try and add some doc on that. > I get the following error when fetching and merging from upstream: $ git fetch upstream remote: Counting objects: 3, done. remote: Compressing objects: 100% (3/3), done. Unpacking objects: 100% (3/3), done. remote: Total 3 (delta 0), reused 1 (delta 0) >From https://github.com/opendnssec/SoftHSMv2 * [new branch] master -> upstream/master $ git merge --ff-only upstream/master master fatal: Not possible to fast-forward, aborting. But it works when I do: $ git merge upstream/master Updating 71eb9bb..89859e8 Fast-forward src/bin/dump/softhsm-dump-db.cpp | 1 + 1 file changed, 1 insertion(+) -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 7 08:50:59 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 09:50:59 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: On Fri, Feb 7, 2014 at 9:34 AM, Rickard Bellgrim wrote: > $ git merge --ff-only upstream/master master > $ git merge upstream/master > What branch where you on when you did merge without --ff-only? -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From rickard at opendnssec.org Fri Feb 7 09:12:16 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Fri, 7 Feb 2014 10:12:16 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: On Fri, Feb 7, 2014 at 9:50 AM, Jerry Lundstr?m wrote: > On Fri, Feb 7, 2014 at 9:34 AM, Rickard Bellgrim wrote: > >> $ git merge --ff-only upstream/master master >> $ git merge upstream/master >> > > What branch where you on when you did merge without --ff-only? > master for SoftHSMv2. // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 7 09:12:39 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 10:12:39 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: On Fri, Feb 7, 2014 at 9:50 AM, Jerry Lundstr?m wrote: > On Fri, Feb 7, 2014 at 9:34 AM, Rickard Bellgrim wrote: > >> $ git merge --ff-only upstream/master master >> $ git merge upstream/master >> > > What branch where you on when you did merge without --ff-only? > I missed that this was SoftHSMv2 and there is only one branch. What git version are you running? -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From rickard at opendnssec.org Fri Feb 7 09:35:15 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Fri, 7 Feb 2014 10:35:15 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: On Fri, Feb 7, 2014 at 10:12 AM, Jerry Lundstr?m wrote: > On Fri, Feb 7, 2014 at 9:50 AM, Jerry Lundstr?m wrote: > >> On Fri, Feb 7, 2014 at 9:34 AM, Rickard Bellgrim wrote: >> >>> $ git merge --ff-only upstream/master master >>> $ git merge upstream/master >>> >> >> What branch where you on when you did merge without --ff-only? >> > > I missed that this was SoftHSMv2 and there is only one branch. > > What git version are you running? > git version 1.7.9.5 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 7 09:42:25 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 10:42:25 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: I have my own SoftHSMv2 fork now but I am unable to replicate the problem (git 1.8), --ff-only works and it's there to prevent merge commits. I don't know why your git did not merge with --ff-only but then merged with ff. $ git fetch upstream remote: Counting objects: 16, done. remote: Compressing objects: 100% (8/8), done. remote: Total 11 (delta 8), reused 6 (delta 3) Unpacking objects: 100% (11/11), done. >From https://github.com/opendnssec/SoftHSMv2 d18258d..ba823f4 master -> upstream/master $ git merge --ff-only upstream/master master Updating d18258d..ba823f4 Fast-forward README.md | 4 ++-- m4/acx_crypto_backend.m4 | 16 ++++------------ 2 files changed, 6 insertions(+), 14 deletions(-) -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From rickard at opendnssec.org Fri Feb 7 09:59:02 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Fri, 7 Feb 2014 10:59:02 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: On Fri, Feb 7, 2014 at 10:42 AM, Jerry Lundstr?m wrote: > I have my own SoftHSMv2 fork now but I am unable to replicate the problem > (git 1.8), --ff-only works and it's there to prevent merge commits. I don't > know why your git did not merge with --ff-only but then merged with ff. > It also worked when I removed the last part of the command: $ git merge --ff-only upstream/master Maybe a difference in the two versions... // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 7 10:30:00 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 11:30:00 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: <-744347670783291655@unknownmsgid> On 7 feb 2014, at 10:59, Rickard Bellgrim wrote: It also worked when I removed the last part of the command: $ git merge --ff-only upstream/master Maybe a difference in the two versions... Yeah, reading the git doc now. Might be my misstake actually and my versions being smarter then older version. Think I need to redo the doc with a lower version. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 7 11:00:28 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 12:00:28 +0100 Subject: [Opendnssec-develop] Re: Reinstallation of testing platforms about to begin... In-Reply-To: References: <992A43D4-7B6B-4691-A5C2-3CBC933EFE5C@opendnssec.org> Message-ID: <3286348727184959693@unknownmsgid> Hi, The wonderful pthread cb segfault in sqlite is back in freebsd delaying the use of the new platforms for jenkins. But all the new platforms except redhat will be up and added to the jenkins jobs by thenn end of the day. Ssh keys are now managed by dasbot and all the old readonly keys has been added so everyone should have access now that had access. New keys are added by me so email me a key if you need access. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 7 12:56:28 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 13:56:28 +0100 Subject: [Opendnssec-develop] About assert()... Message-ID: $ grep assert branches/OpenDNSSEC-1.3 -r | wc -l 614 $ grep assert branches/OpenDNSSEC-1.4 -r | wc -l 805 $ grep assert trunk/OpenDNSSEC -r | wc -l 943 We should handle errors, not just die. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From yuri at nlnetlabs.nl Fri Feb 7 13:30:17 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Fri, 07 Feb 2014 14:30:17 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: References: Message-ID: <52F4DFE9.8070802@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > We should handle errors, not just die. And why is that? Assertions are meant for things that REALLY never should go wrong. If you hit one you've hit a programming mistake. Crash early and often I'd say. I would go as far as saying good code has LOTS of assertions. - -- Composed on an actual keyboard: all typos genuine. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlL03+kACgkQI3PTR4mhavi+igCgyAm3nF1Fs81mOAK+yb/jnbGH fJMAn3tqN9C1MyQ6JTdlhbbQNoLYCfUo =ttHB -----END PGP SIGNATURE----- From jerry at opendnssec.org Fri Feb 7 13:45:52 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 14:45:52 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <52F4DFE9.8070802@nlnetlabs.nl> References: <52F4DFE9.8070802@nlnetlabs.nl> Message-ID: On 07 Feb 2014, at 14:30 , Yuri Schaeffer wrote: > Assertions are meant for things that REALLY never should go wrong. If > you hit one you've hit a programming mistake. Crash early and often > I'd say. I would go as far as saying good code has LOTS of assertions. Instead of dying in the middle of something essentially breaking and corrupting databases and files I?d rather see that the functions return an error and the callers handles that error. Looking a bit into the code there is a lot of assert that do not make any sense, like this (trunk): if (!kl || !key || !key->locator) { ods_log_error("[%s] push failed: no list or no key", key_str); return ODS_STATUS_ASSERT_ERR; } ods_log_assert(kl); ods_log_assert(key); Guess its just leftover code, spring cleaning may be in order. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From rickard at opendnssec.org Fri Feb 7 14:30:18 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Fri, 7 Feb 2014 15:30:18 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 Message-ID: Hi Jakob and I have gone through the open tickets for SoftHSMv2. Many of them have been finished or fixed during this week. We are now confident enough to start the release of the first alpha version. I just have one last pull request for the NEWS-file. https://github.com/opendnssec/SoftHSMv2/pull/48 Jerry, would you like to initiate the release? // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 7 14:32:18 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 15:32:18 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: Message-ID: <0596AE42-1EE5-49A5-A025-B393D10D920A@opendnssec.org> On 07 Feb 2014, at 15:30 , Rickard Bellgrim wrote: > Jerry, would you like to initiate the release? Yes, I?m working on Jenkins/build-bot for SoftHSMv2 now. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jakob at kirei.se Fri Feb 7 14:32:54 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Fri, 7 Feb 2014 15:32:54 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <0596AE42-1EE5-49A5-A025-B393D10D920A@opendnssec.org> References: <0596AE42-1EE5-49A5-A025-B393D10D920A@opendnssec.org> Message-ID: <0C2004C2-4553-403B-A7CE-9845735B339C@kirei.se> On 7 feb 2014, at 15:32, Jerry Lundstr?m wrote: > Yes, I?m working on Jenkins/build-bot for SoftHSMv2 now. Will you add targets for OpenSSL builds as well? #later jakob From jerry at opendnssec.org Fri Feb 7 14:45:36 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 15:45:36 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <0C2004C2-4553-403B-A7CE-9845735B339C@kirei.se> References: <0596AE42-1EE5-49A5-A025-B393D10D920A@opendnssec.org> <0C2004C2-4553-403B-A7CE-9845735B339C@kirei.se> Message-ID: <5F70BD25-0625-4AA5-B228-C6EE2EE14936@opendnssec.org> On 07 Feb 2014, at 15:32 , Jakob Schlyter wrote: > Will you add targets for OpenSSL builds as well? #later Can do. #now-ish -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Fri Feb 7 14:47:19 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 15:47:19 +0100 Subject: [Opendnssec-develop] Be very very careful with bash && chains... Message-ID: <84C9A513-F33B-4D8E-9183-BB90D28FC1CD@opendnssec.org> Hi, Just want to remind all that you need to be careful with the && chains in bash, saw this: if [ -n "$HAVE_MYSQL" ]; then ods_setup_conf conf.xml conf-mysql.xml else ods_setup_conf conf.xml conf.xml fi && case "$DISTRIBUTION" in freebsd ) return 0 ;; esac ods_reset_env && The && chain is broken by the case, since its not included then ods_reset_env and all the rest will run even if ods_setup_conf fails. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Fri Feb 7 15:03:49 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 16:03:49 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <0C2004C2-4553-403B-A7CE-9845735B339C@kirei.se> References: <0596AE42-1EE5-49A5-A025-B393D10D920A@opendnssec.org> <0C2004C2-4553-403B-A7CE-9845735B339C@kirei.se> Message-ID: <13657BD2-87FF-4203-B121-55492862315A@opendnssec.org> On 07 Feb 2014, at 15:32 , Jakob Schlyter wrote: > Will you add targets for OpenSSL builds as well? #later About this, is it sufficient that Botan is used for pull requests and both Botan and OpenSSL is tested after pull request mergers? This is the same senario with OpenDNSSEC and SQLite3 vs MySQL. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jakob at kirei.se Fri Feb 7 15:04:53 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Fri, 7 Feb 2014 16:04:53 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <13657BD2-87FF-4203-B121-55492862315A@opendnssec.org> References: <0596AE42-1EE5-49A5-A025-B393D10D920A@opendnssec.org> <0C2004C2-4553-403B-A7CE-9845735B339C@kirei.se> <13657BD2-87FF-4203-B121-55492862315A@opendnssec.org> Message-ID: On 7 feb 2014, at 16:03, Jerry Lundstr?m wrote: > On 07 Feb 2014, at 15:32 , Jakob Schlyter wrote: > >> Will you add targets for OpenSSL builds as well? #later > > About this, is it sufficient that Botan is used for pull requests and both Botan and OpenSSL is tested after pull request mergers? > > This is the same senario with OpenDNSSEC and SQLite3 vs MySQL. I'd prefer if we can build with all backends for pull requests. jakob From jerry at opendnssec.org Fri Feb 7 15:22:26 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 7 Feb 2014 16:22:26 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: Message-ID: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> On 07 Feb 2014, at 15:30 , Rickard Bellgrim wrote: > Jakob and I have gone through the open tickets for SoftHSMv2. Many of them have been finished or fixed during this week. We are now confident enough to start the release of the first alpha version. One more for the road https://issues.opendnssec.org/browse/SOFTHSM-67 . -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Sat Feb 8 18:44:20 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Sat, 8 Feb 2014 19:44:20 +0100 Subject: [Opendnssec-develop] Re: Reinstallation of testing platforms about to begin... In-Reply-To: <3286348727184959693@unknownmsgid> References: <992A43D4-7B6B-4691-A5C2-3CBC933EFE5C@opendnssec.org> <3286348727184959693@unknownmsgid> Message-ID: Hi, FreeBSD 9 pthread cb segfault has been solved and all tests that was previously disabled because of this has been enabled again and are successful. All jobs are built and tested on the new platforms and everything is operational again. Only thing to note is that a new problem popped up on two platforms and it seems related to a newer dig version then we had on the old platforms and this problem has been logged https://issues.opendnssec.org/browse/OPENDNSSEC-544 . The new Red Hat platform is left to be done and we are waiting on an activation key which we will hopefully get next week. There is also the issue with bind on the old platform and I will be looking into that starting next week to try and get bind on all platforms so we can run this tests everywhere. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthijs at nlnetlabs.nl Mon Feb 10 09:12:32 2014 From: matthijs at nlnetlabs.nl (Matthijs Mekking) Date: Mon, 10 Feb 2014 10:12:32 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: References: <52F4DFE9.8070802@nlnetlabs.nl> Message-ID: <52F89800.6090203@nlnetlabs.nl> On 02/07/2014 02:45 PM, Jerry Lundstr?m wrote: > On 07 Feb 2014, at 14:30 , Yuri Schaeffer wrote: > >> Assertions are meant for things that REALLY never should go wrong. If >> you hit one you've hit a programming mistake. Crash early and often >> I'd say. I would go as far as saying good code has LOTS of assertions. > > Instead of dying in the middle of something essentially breaking and corrupting databases and files I?d rather see that the functions return an error and the callers handles that error. I agree that having a lot of assertions is good practice. However, I have a hard time of putting them in the right place. Below is an example of where I was in doubt, and the ods_log_assert calls do not make sense anymore. > Looking a bit into the code there is a lot of assert that do not make any sense, like this (trunk): > > if (!kl || !key || !key->locator) { > ods_log_error("[%s] push failed: no list or no key", key_str); > return ODS_STATUS_ASSERT_ERR; > } > ods_log_assert(kl); > ods_log_assert(key); In this specific case, there may be not anything useful to do for a particular zone anymore, but other zones can continue to be signed. Best regards, Matthijs > > Guess its just leftover code, spring cleaning may be in order. > > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ > > > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop > From jerry at opendnssec.org Mon Feb 10 10:05:57 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 11:05:57 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> Message-ID: On 07 Feb 2014, at 16:22 , Jerry Lundstr?m wrote: > On 07 Feb 2014, at 15:30 , Rickard Bellgrim wrote: > >> Jakob and I have gone through the open tickets for SoftHSMv2. Many of them have been finished or fixed during this week. We are now confident enough to start the release of the first alpha version. > > One more for the road https://issues.opendnssec.org/browse/SOFTHSM-67 . I found these two also which are pretty non critical, shall we go ahead with the release? SOFTHSM-68 - configuring using botan with ECC fails and gives notice on a change to files that does not exist anymore SOFTHSM-69 - Botan GOST fails to build if ECC is disabled SOFTHSM-67 is resolved by https://github.com/opendnssec/SoftHSMv2/pull/47 . -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From rickard at opendnssec.org Mon Feb 10 10:24:36 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Mon, 10 Feb 2014 11:24:36 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> Message-ID: > > I found these two also which are pretty non critical, shall we go ahead > with the release? > > SOFTHSM-68 - configuring using botan with ECC fails and gives notice on a > change to files that does not exist anymore > SOFTHSM-69 - Botan GOST fails to build if ECC is disabled > > SOFTHSM-67 is resolved by https://github.com/opendnssec/SoftHSMv2/pull/47. > As we usually say: Release early, release often I can start working on those issues and send a pull request to the upcoming development branch. // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Mon Feb 10 10:24:55 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 11:24:55 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <52F89800.6090203@nlnetlabs.nl> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> Message-ID: <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> On 10 Feb 2014, at 10:12 , Matthijs Mekking wrote: > I agree that having a lot of assertions is good practice. However, I > have a hard time of putting them in the right place. Below is an example > of where I was in doubt, and the ods_log_assert calls do not make sense > anymore. If you are in doubt maybe the best way is not to use assert since it will kill the program. It is always better to provide errors that the calling code can handle. > In this specific case, there may be not anything useful to do for a > particular zone anymore, but other zones can continue to be signed. But the asset code here will always be successful since faulty variables are handled in the code above the asserts. With that in mind the numbers of assert we have in the code base is a bit misleading if there is a lot of cases where the asset code is like this case. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jakob at kirei.se Mon Feb 10 10:27:11 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Mon, 10 Feb 2014 11:27:11 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> Message-ID: <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> On 10 feb 2014, at 11:24, Rickard Bellgrim wrote: > As we usually say: Release early, release often I agree, release 2.0.0a1 now and initiate develop branch. jakob From jerry at opendnssec.org Mon Feb 10 10:30:36 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 11:30:36 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> Message-ID: On 10 Feb 2014, at 11:27 , Jakob Schlyter wrote: > I agree, release 2.0.0a1 now and initiate develop branch. Will do it today. Going to merge my pull request after lunch and restrict access to the repository while I setup the develop branch. Are we going to restrict push access to the repository as we do with the others so all users, even developers, must use pull requests? -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From matthijs at nlnetlabs.nl Mon Feb 10 10:33:53 2014 From: matthijs at nlnetlabs.nl (Matthijs Mekking) Date: Mon, 10 Feb 2014 11:33:53 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> Message-ID: <52F8AB11.4000808@nlnetlabs.nl> On 02/10/2014 11:24 AM, Jerry Lundstr?m wrote: > On 10 Feb 2014, at 10:12 , Matthijs Mekking wrote: > >> I agree that having a lot of assertions is good practice. However, I >> have a hard time of putting them in the right place. Below is an example >> of where I was in doubt, and the ods_log_assert calls do not make sense >> anymore. > > If you are in doubt maybe the best way is not to use assert since it will kill the program. It is always better to provide errors that the calling code can handle. Assertions are quite handy for in jenkins (see OPENDNSSEC-544). In some cases they also may be useful in releases, because if the assertion did not kill the program, a segfault probably will. If not, something terribly wrong may happen. So sometimes dying is just the lesser of two evils... > >> In this specific case, there may be not anything useful to do for a >> particular zone anymore, but other zones can continue to be signed. > > But the asset code here will always be successful since faulty variables are handled in the code above the asserts. > > With that in mind the numbers of assert we have in the code base is a bit misleading if there is a lot of cases where the asset code is like this case. > > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ > > > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop > From jakob at kirei.se Mon Feb 10 10:34:07 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Mon, 10 Feb 2014 11:34:07 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> Message-ID: <8F77701F-1669-44FF-A86C-894ECB50EDC3@kirei.se> On 10 feb 2014, at 11:30, Jerry Lundstr?m wrote: > Are we going to restrict push access to the repository as we do with the others so all users, even developers, must use pull requests? Yes, please. Restrict push to the "release-managers" group. jakob From jerry at opendnssec.org Mon Feb 10 11:47:09 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 12:47:09 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <52F8AB11.4000808@nlnetlabs.nl> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> Message-ID: <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> On 10 Feb 2014, at 11:33 , Matthijs Mekking wrote: > In some cases they also may be useful in releases, because if the > assertion did not kill the program, a segfault probably will. If not, > something terribly wrong may happen. So sometimes dying is just the > lesser of two evils... ... and even better would be if it reported the error, handled the problem and continued to operate so that states are kept non-corrupt. You might argue that an assert is really needed since a (for example) function should never be called with NULL. But what if something did call it with NULL, there might be a situation where the system is temporarily out of memory or that is was called from an untested code path or some other strange situation. Is it then our praxis, our coding standard to have the program just die? I?d really hope not. I can not really see how asserts are useful in stable releases of a daemon which has multiple states (zones) like we do. For testing? My point for bringing this all up is to hopefully improved the quality of our code base in the future. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Mon Feb 10 12:04:04 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 13:04:04 +0100 Subject: [Opendnssec-develop] Preparing SoftHSMv2 for release Message-ID: <7EE41F0B-5550-42AE-B5AB-BF09AB11C2EE@opendnssec.org> Hi all, I?m going to start preparing SoftHSMv2 for release and will be making changes to the repository that may invalidate your fork. If you have pending pull request submissions or any other work already done these can be submitted by making pull requests from those branches to the develop branch that will be created shortly. If you get problems with your fork then the easiest way to fix that it by removing your fork locally and on GitHub and then reforking. Other solutions may be to remove your master branch locally and remote and recreate it based on the new upstream/master branch. Please note that all future work should now be based on the develop branch. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From matthijs at nlnetlabs.nl Mon Feb 10 12:13:03 2014 From: matthijs at nlnetlabs.nl (Matthijs Mekking) Date: Mon, 10 Feb 2014 13:13:03 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> Message-ID: <52F8C24F.5020401@nlnetlabs.nl> On 02/10/2014 12:47 PM, Jerry Lundstr?m wrote: > On 10 Feb 2014, at 11:33 , Matthijs Mekking wrote: > >> In some cases they also may be useful in releases, because if the >> assertion did not kill the program, a segfault probably will. If not, >> something terribly wrong may happen. So sometimes dying is just the >> lesser of two evils... > > ... and even better would be if it reported the error, handled the problem and continued to operate so that states are kept non-corrupt. > > You might argue that an assert is really needed since a (for example) function should never be called with NULL. > > But what if something did call it with NULL, there might be a situation where the system is temporarily out of memory or that is was called from an untested code path or some other strange situation. Is it then our praxis, our coding standard to have the program just die? I?d really hope not. > > I can not really see how asserts are useful in stable releases of a daemon which has multiple states (zones) like we do. For testing? Exactly. For testing and debugging. Best regards, Matthijs > > My point for bringing this all up is to hopefully improved the quality of our code base in the future. > > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ > From jerry at opendnssec.org Mon Feb 10 12:16:30 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 13:16:30 +0100 Subject: [Opendnssec-develop] Release management in Git and with Git Flow Message-ID: <43642C71-7E97-4598-9E20-F1F3CB9F1E78@opendnssec.org> Hi, Just a reminder, now with Git and Git Flow we do all the version bumping when we create the release branch and tag which is done by the release manager. So don?t go bumping the version now you hear! :) -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Mon Feb 10 13:54:12 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 14:54:12 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> Message-ID: <09AD505C-317C-44AC-9259-F853CC885D45@opendnssec.org> On 10 Feb 2014, at 11:30 , Jerry Lundstr?m wrote: > Will do it today. And its released. Tag https://github.com/opendnssec/SoftHSMv2/releases/tag/2.0.0a1 Tarball https://dist.opendnssec.org/source/testing/softhsm-2.0.0a1.tar.gz Rickard, will you do a short release email to user list maybe? -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Mon Feb 10 14:26:52 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 15:26:52 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <52F8C24F.5020401@nlnetlabs.nl> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> <52F8C24F.5020401@nlnetlabs.nl> Message-ID: <4B5A28CB-0EB1-4B1F-8EE0-BAEF26377FAC@opendnssec.org> On 10 Feb 2014, at 13:13 , Matthijs Mekking wrote: >> I can not really see how asserts are useful in stable releases of a daemon which has multiple states (zones) like we do. For testing? > > Exactly. For testing and debugging. I accidentally removed a part there before sending, meant ?For testing? Sure.?. Of course for testing and debugging but 1.3 and 1.4 shouldn?t really be testing still. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From rickard at opendnssec.org Mon Feb 10 14:27:38 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Mon, 10 Feb 2014 15:27:38 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <09AD505C-317C-44AC-9259-F853CC885D45@opendnssec.org> References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> <09AD505C-317C-44AC-9259-F853CC885D45@opendnssec.org> Message-ID: > > Rickard, will you do a short release email to user list maybe? > Done, anyone updating the web? -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Mon Feb 10 14:43:14 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 10 Feb 2014 15:43:14 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: <09AD505C-317C-44AC-9259-F853CC885D45@opendnssec.org> References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> <09AD505C-317C-44AC-9259-F853CC885D45@opendnssec.org> Message-ID: <92C70C90-8731-4ACD-A8DD-2E995B00BC72@opendnssec.org> On 10 Feb 2014, at 14:54 , Jerry Lundstr?m wrote: > And its released. Jenkins jobs for building develop and master has been added, master is automatically built but I am unsure if develop is needed since all pull requests should be built and tested by the bot really. https://jenkins.opendnssec.org/view/softhsm/ -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Mon Feb 10 15:09:39 2014 From: sara at sinodun.com (Sara Dickinson) Date: Mon, 10 Feb 2014 15:09:39 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> Message-ID: <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> On 6 Feb 2014, at 14:49, Jerry Lundstr?m wrote: Hi All, I have added a few extra bullet points and heading to the workflow page - please review my changes and make sure they all make sense! > >> - If you do delete your feature branch, or need to cherry pick commits to port them then I imagine you use ?merge?? Jerry - could you please document this workflow too as I suspect this is going to be much more likely in practice than being able to do a clean rebase? > > Ehm, no you don?t merge, you cherry-pick (yes its a actual git command). > > I can try and add some doc on that. Jerry - that would be great - thank you. I think this is how most people will work so I think we need this asap. For example, if I have commits I made in subversion that I will port after we move I will have to cherry pick right? > >> Pull requests: >> >> It is still not clear to me exactly what happens with the review stage or the tests. > > We can add more later on but to begin we got ?build? now and it runs all tests, new and modified, which is just what happens now if you do a commit. Question: Right now who has permission to run what bot commands? In the beginning I think I hear that the plan is that Jerry/Jakob will run every test on every pull request (not the developer)? Is this right? Will you do this immediately on receiving the request or only after review? How long does this take for the production releases - 2 hours I think for both DBs? Have I understood correctly that the aim (for pull requests that come from the development team) is to move quite quickly to a point where each developer starts (at least) a build on submitting a pull request and deals with any build/test failures before getting anyone else involved (reviewers or release manager)? This seems like one of the big wins to me that as a developer I can do this step by myself without the code actually going into the repo? Then it is the developer that co-ordinates the review and so the 'Jerry/Jakob/release manager' role is essentially just to do whatever extra review/testing is necessary as a sanity check before merging. Is this how people see this process developing? > >> b) Then who decides who should review it? >> - Seems sensible that the developer should requests a specific reviewer in the pull request comment if they want one? >> - If it doesn?t need a full blown review what happens - Jerry/Jakob will you give it the once over to see what you think? >> - If we want to give other developers who will be watching the pull requests time to comment how long should we wait before moving forward with the process? > > Do we really need this in writing now? Think common sense here will prevail. Hum, it isn?t rocket science to define a basic process. I would like to know what happens after Monday when I put my first pull request in :-) And also please remember that we are an extended, part-time, geographically dispersed team and the more guidance we can give the better. Sara. From sara at sinodun.com Mon Feb 10 15:19:24 2014 From: sara at sinodun.com (Sara Dickinson) Date: Mon, 10 Feb 2014 15:19:24 +0000 Subject: [Opendnssec-develop] RE: Move to git Message-ID: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> Hi, So many questions!! 1) Jerry - there are quite a few confluence pages that currently reference svn e.g. https://wiki.opendnssec.org/display/OpenDNSSEC/Issue+tracking+process https://wiki.opendnssec.org/display/OpenDNSSEC/Code+Review+process https://wiki.opendnssec.org/display/OpenDNSSEC/Release+Engineering https://wiki.opendnssec.org/display/OpenDNSSEC/How+To+Develop+tests+locally Are you going to update all of these when we move? 2) From what I understand the svn trunk/OpenDNSSEC will form the basis of the new OpenDNSSEC git repo. Can we clarify what happens to the two remaining top level directories in the svn repo under trunk trunk/testing trunk/utils 3) Who currently has permission to accept pull requests. It was suggest that: Jerry will do this as routine, Jakob is backup but others (Matthijs, Yuri, Patrik, Sara) should have the ability to do this as an exception e.g. hotfix, problems with regression tests. This sounds a good place to start - is it implemented? Thanks Sara. From sara at sinodun.com Mon Feb 10 15:51:03 2014 From: sara at sinodun.com (Sara Dickinson) Date: Mon, 10 Feb 2014 15:51:03 +0000 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> <09AD505C-317C-44AC-9259-F853CC885D45@opendnssec.org> Message-ID: On 10 Feb 2014, at 14:27, Rickard Bellgrim wrote: > Rickard, will you do a short release email to user list maybe? > > Done, anyone updating the web? www.opendnssec.org done. Are you going to update the JIRA versions or do you want me to do that too? Sara. From sara at sinodun.com Mon Feb 10 16:37:57 2014 From: sara at sinodun.com (Sara Dickinson) Date: Mon, 10 Feb 2014 16:37:57 +0000 Subject: [Opendnssec-develop] Re: jerry r7640 - in trunk/OpenDNSSEC/testing/test-cases-daily.d: enforcer.keys.rollovers_many enforcer.ksmutil.key_generate_manual In-Reply-To: <20140208182027.B90D04C6@svn.opendnssec.org> References: <20140208182027.B90D04C6@svn.opendnssec.org> Message-ID: On 8 Feb 2014, at 18:20, commits at svn.opendnssec.org wrote: > Log: > Enable tests on FreeBSD because the pthread segfault has been solved > Great news. Care to share the secret? Sara. From sara at sinodun.com Mon Feb 10 16:39:12 2014 From: sara at sinodun.com (Sara Dickinson) Date: Mon, 10 Feb 2014 16:39:12 +0000 Subject: [Opendnssec-develop] Reinstallation of testing platforms about to begin... In-Reply-To: References: <992A43D4-7B6B-4691-A5C2-3CBC933EFE5C@opendnssec.org> <3286348727184959693@unknownmsgid> Message-ID: <0BB179CE-95B5-4D4E-9A75-37640D38B215@sinodun.com> On 8 Feb 2014, at 18:44, Jerry Lundstr?m wrote: > All jobs are built and tested on the new platforms and everything is operational again. Excellent - well done! From jakob at kirei.se Mon Feb 10 20:19:01 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Mon, 10 Feb 2014 21:19:01 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> Message-ID: <9D1DF9AD-EB92-43DF-A66B-443762221854@kirei.se> On 10 feb 2014, at 16:19, Sara Dickinson wrote: > 3) Who currently has permission to accept pull requests. It was suggest that: Jerry will do this as routine, Jakob is backup but others (Matthijs, Yuri, Patrik, Sara) should have the ability to do this as an exception e.g. hotfix, problems with regression tests. This sounds a good place to start - is it implemented? We have two (2) groups: - https://github.com/orgs/opendnssec/teams/opendnssec-release-managers - https://github.com/orgs/opendnssec/teams/opendnssec-release-override Given that all users on the 2nd list CONFIRM to me that they will not accept pull request unless instructed to do so by Sara, Jerry or me, I'm happy to assigned push/pullreqaccept permissions to this group. It's very easy to accidentally accept requests or push to the main repo, so my strong words are serious. I've made sure my forks has a a HTTPS (readonly) upstream URL so I don't accidentally push stuff and under non-release conditions I only accept pull requests via the web gui. jakob From jakob at kirei.se Mon Feb 10 20:22:32 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Mon, 10 Feb 2014 21:22:32 +0100 Subject: [Opendnssec-develop] SoftHSM 2.0.0a1 In-Reply-To: References: <7E2367CB-8497-45EF-B1C1-873BA12E2134@opendnssec.org> <69CEEE9A-67AB-4482-AC03-A790A3F4EF55@kirei.se> <09AD505C-317C-44AC-9259-F853CC885D45@opendnssec.org> Message-ID: <00F135AC-E499-4901-8D45-6C20D20C4469@kirei.se> On 10 feb 2014, at 16:51, Sara Dickinson wrote: > Are you going to update the JIRA versions or do you want me to do that too? I've fixed the version. jakob From matthijs at nlnetlabs.nl Mon Feb 10 22:04:30 2014 From: matthijs at nlnetlabs.nl (Matthijs Mekking) Date: Mon, 10 Feb 2014 23:04:30 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <4B5A28CB-0EB1-4B1F-8EE0-BAEF26377FAC@opendnssec.org> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> <52F8C24F.5020401@nlnetlabs.nl> <4B5A28CB-0EB1-4B1F-8EE0-BAEF26377FAC@opendnssec.org> Message-ID: <52F94CEE.604@nlnetlabs.nl> On 02/10/2014 03:26 PM, Jerry Lundstr?m wrote: > On 10 Feb 2014, at 13:13 , Matthijs Mekking wrote: > >>> I can not really see how asserts are useful in stable releases of a daemon which has multiple states (zones) like we do. For testing? >> >> Exactly. For testing and debugging. > > I accidentally removed a part there before sending, meant ?For testing? Sure.?. Of course for testing and debugging but 1.3 and 1.4 shouldn?t really be testing still. Of course we are still testing 1.3 and 1.4. We are still making patch releases right? Those assertions tell us we don't break stuff when writing new code. > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ > From jerry at opendnssec.org Tue Feb 11 07:01:46 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 11 Feb 2014 08:01:46 +0100 Subject: [Opendnssec-develop] Re: jerry r7640 - in trunk/OpenDNSSEC/testing/test-cases-daily.d: enforcer.keys.rollovers_many enforcer.ksmutil.key_generate_manual In-Reply-To: References: <20140208182027.B90D04C6@svn.opendnssec.org> Message-ID: On Mon, Feb 10, 2014 at 5:37 PM, Sara Dickinson wrote: > > On 8 Feb 2014, at 18:20, commits at svn.opendnssec.org wrote: > > > Enable tests on FreeBSD because the pthread segfault has been solved > > Great news. Care to share the secret? > No magic, compile SQLite our selfs and use the most current version which seems fixed. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Tue Feb 11 07:24:34 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 11 Feb 2014 08:24:34 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> Message-ID: On Mon, Feb 10, 2014 at 4:09 PM, Sara Dickinson wrote: > > I have added a few extra bullet points and heading to the workflow page - > please review my changes and make sure they all make sense! > "however remember that this will they are dependant on each other for being accepted into the upstream repository." ..that this will they are.. ? :) > Jerry - that would be great - thank you. I think this is how most people > will work so I think we need this asap. For example, if I have commits I > made in subversion that I will port after we move I will have to cherry > pick right? > Yes. > Question: Right now who has permission to run what bot commands? > Should be all of us. > In the beginning I think I hear that the plan is that Jerry/Jakob will run > every test on every pull request (not the developer)? Is this right? Will > you do this immediately on receiving the request or only after review? How > long does this take for the production releases - 2 hours I think for both > DBs? > Currently: - After review. - Only smoke. - Only SQLite. - 10-20mins. > Have I understood correctly that the aim (for pull requests that come from > the development team) is to move quite quickly to a point where each > developer starts (at least) a build on submitting a pull request and deals > with any build/test failures before getting anyone else involved (reviewers > or release manager)? This seems like one of the big wins to me that as a > developer I can do this step by myself without the code actually going into > the repo? Then it is the developer that co-ordinates the review and so the > 'Jerry/Jakob/release manager' role is essentially just to do whatever extra > review/testing is necessary as a sanity check before merging. Is this how > people see this process developing? > I can't answer for people but we have the option do allow developers to build and test their feature branch. Doing this does not really remove the requirement to have a separate set of eyes to look at the code. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Tue Feb 11 07:34:36 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 11 Feb 2014 08:34:36 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> Message-ID: On Mon, Feb 10, 2014 at 4:19 PM, Sara Dickinson wrote: > > 1) Jerry - there are quite a few confluence pages that currently reference > svn e.g. > https://wiki.opendnssec.org/display/OpenDNSSEC/Issue+tracking+process > https://wiki.opendnssec.org/display/OpenDNSSEC/Code+Review+process > https://wiki.opendnssec.org/display/OpenDNSSEC/Release+Engineering > https://wiki.opendnssec.org/display/OpenDNSSEC/How+To+Develop+tests+locally > > Are you going to update all of these when we move? > Had no plans of doing that right now. Release Engineering will be updated soon and I can look at test locally. Can you look at the others? > 2) From what I understand the svn trunk/OpenDNSSEC will form the basis of > the new OpenDNSSEC git repo. Can we clarify what happens to the two > remaining top level directories in the svn repo under trunk > Yes and no. The OpenDNSSEC code base will be center of the git repository but all history of OpenDNSSEC will be in the repository (because my test imports when trying to exclude things like SoftHSM fails, think its too many cross dependencies.) > trunk/testing > trunk/utils > Will get their own repositories. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Tue Feb 11 08:03:14 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 11 Feb 2014 09:03:14 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <52F94CEE.604@nlnetlabs.nl> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> <52F8C24F.5020401@nlnetlabs.nl> <4B5A28CB-0EB1-4B1F-8EE0-BAEF26377FAC@opendnssec.org> <52F94CEE.604@nlnetlabs.nl> Message-ID: On Mon, Feb 10, 2014 at 11:04 PM, Matthijs Mekking wrote: > > Of course we are still testing 1.3 and 1.4. We are still making patch > releases right? Those assertions tell us we don't break stuff when > writing new code. > I think we are saying "testing" but meaning different things. Feels like your talking about testing as in Jenkins, I mean testing as in development, alpha and beta releases. Assert when in alpha or beta is fine by me but not after that. There are better way to check that we don't break the code then asserts and that is to have propper error handling rather then just dying. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthijs at nlnetlabs.nl Tue Feb 11 08:38:15 2014 From: matthijs at nlnetlabs.nl (Matthijs Mekking) Date: Tue, 11 Feb 2014 09:38:15 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> <52F8C24F.5020401@nlnetlabs.nl> <4B5A28CB-0EB1-4B1F-8EE0-BAEF26377FAC@opendnssec.org> <52F94CEE.604@nlnetlabs.nl> Message-ID: <52F9E177.9070103@nlnetlabs.nl> Alright, I think I can safely say we agree to disagree. On 02/11/2014 09:03 AM, Jerry Lundstr?m wrote: > On Mon, Feb 10, 2014 at 11:04 PM, Matthijs Mekking > > wrote: > > > Of course we are still testing 1.3 and 1.4. We are still making patch > releases right? Those assertions tell us we don't break stuff when > writing new code. > > > I think we are saying "testing" but meaning different things. Feels like > your talking about testing as in Jenkins, I mean testing as in > development, alpha and beta releases. > > Assert when in alpha or beta is fine by me but not after that. > > There are better way to check that we don't break the code then asserts > and that is to have propper error handling rather then just dying. > > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ From yuri at nlnetlabs.nl Tue Feb 11 08:58:11 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Tue, 11 Feb 2014 09:58:11 +0100 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> Message-ID: <52F9E623.1080307@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > But what if something did call it with NULL, there might be a > situation where the system is temporarily out of memory or that is > was called from an untested code path or some other strange > situation. Not a good argument. You should only use assertions when you are sure they will _never_ fail whereas you use a regular check if it could _possibly_ fail. > Is it then our praxis, our coding standard to have the program just > die? I?d really hope not. I'm sorry I am in favour of dying. You might have a point that some/many assertions need to be revised. But I see no objections of using asserts where appropriate. It is a debugging tool, it has nothing to do with error handling. //Yuri - -- Composed on an actual keyboard: all typos genuine. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlL55iMACgkQI3PTR4mhavhs4wCgncBZJopGyPyTO7SxInOIrXq7 Hb4AoIq2IXopFEzBacp/I+qz891LKzP+ =gQ3Z -----END PGP SIGNATURE----- From sara at sinodun.com Tue Feb 11 11:49:51 2014 From: sara at sinodun.com (Sara Dickinson) Date: Tue, 11 Feb 2014 11:49:51 +0000 Subject: [Opendnssec-develop] About assert()... In-Reply-To: <52F9E623.1080307@nlnetlabs.nl> References: <52F4DFE9.8070802@nlnetlabs.nl> <52F89800.6090203@nlnetlabs.nl> <1F5F12FB-5F89-42F5-9C43-02320D3BD871@opendnssec.org> <52F8AB11.4000808@nlnetlabs.nl> <679F2BD8-E5AD-44D5-B7D4-4F0D8FE72051@opendnssec.org> <52F9E623.1080307@nlnetlabs.nl> Message-ID: <43C5F0E1-64D9-49F6-911C-D7B5DDA23B54@sinodun.com> Hi All, I hear lots of valid points, but I?d like to suggest that we take this discussion offline and that the most effective way to reach agreement (or disagreement!) is to add this to the agenda for the upcoming workshop (which will be available later today), where everyone can chip in. We are effectively talking about coding guidelines here (something we don?t have?), which seems a good topic for group discussion. Particularly with a major release/complete re-write of the enforcer in progress, this seem a good opportunity to make some decisions. Sara. On 11 Feb 2014, at 08:58, Yuri Schaeffer wrote: > Signed PGP part > > But what if something did call it with NULL, there might be a > > situation where the system is temporarily out of memory or that is > > was called from an untested code path or some other strange > > situation. > > Not a good argument. You should only use assertions when you are sure > they will _never_ fail whereas you use a regular check if it could > _possibly_ fail. > > > Is it then our praxis, our coding standard to have the program just > > die? I?d really hope not. > > I'm sorry I am in favour of dying. You might have a point that > some/many assertions need to be revised. But I see no objections of > using asserts where appropriate. It is a debugging tool, it has > nothing to do with error handling. > > //Yuri > > -- > Composed on an actual keyboard: all typos genuine. > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop From sara at sinodun.com Tue Feb 11 11:54:09 2014 From: sara at sinodun.com (Sara Dickinson) Date: Tue, 11 Feb 2014 11:54:09 +0000 Subject: [Opendnssec-develop] RE: Developer workshop Message-ID: HI All, Here is a provisional agenda for the workshop - please let me know if you would like to add/change anything. https://wiki.opendnssec.org/display/OpenDNSSEC/Developer+workshop+-+London+Feb+2014 I?m waiting for final confirmation the office site is booked, but this should be a formality. Also - if you have any dietary requirements, please let me know asap. Sara. From jerry at opendnssec.org Tue Feb 11 13:53:55 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 11 Feb 2014 14:53:55 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> Message-ID: <52163B5D-EDC9-49DF-81BD-CBA0ABD4D797@opendnssec.org> On 11 Feb 2014, at 08:34 , Jerry Lundstr?m wrote: > https://wiki.opendnssec.org/display/OpenDNSSEC/Release+Engineering > https://wiki.opendnssec.org/display/OpenDNSSEC/How+To+Develop+tests+locally These pages has been updated for git. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Wed Feb 12 11:12:32 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 11:12:32 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: <9D1DF9AD-EB92-43DF-A66B-443762221854@kirei.se> References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> <9D1DF9AD-EB92-43DF-A66B-443762221854@kirei.se> Message-ID: <7C8D2ECD-F1DD-4451-82FC-64A5AB06D0E0@sinodun.com> On 10 Feb 2014, at 20:19, Jakob Schlyter wrote: > On 10 feb 2014, at 16:19, Sara Dickinson wrote: > >> 3) Who currently has permission to accept pull requests. It was suggest that: Jerry will do this as routine, Jakob is backup but others (Matthijs, Yuri, Patrik, Sara) should have the ability to do this as an exception e.g. hotfix, problems with regression tests. This sounds a good place to start - is it implemented? > > We have two (2) groups: > > - https://github.com/orgs/opendnssec/teams/opendnssec-release-managers The page doesn?t seem to exist - but the error message is worth seeing :-) > - https://github.com/orgs/opendnssec/teams/opendnssec-release-override > > Given that all users on the 2nd list CONFIRM to me that they will not accept pull request unless instructed to do so by Sara, Jerry or me, I'm happy to assigned push/pullreqaccept permissions to this group. Sounds like a good start. > It's very easy to accidentally accept requests or push to the main repo, so my strong words are serious. I've made sure my forks has a a HTTPS (readonly) upstream URL so I don't accidentally push stuff and under non-release conditions I only accept pull requests via the web gui. OK - noted. Sara. From jerry at opendnssec.org Wed Feb 12 11:17:05 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 12 Feb 2014 12:17:05 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <7C8D2ECD-F1DD-4451-82FC-64A5AB06D0E0@sinodun.com> References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> <9D1DF9AD-EB92-43DF-A66B-443762221854@kirei.se> <7C8D2ECD-F1DD-4451-82FC-64A5AB06D0E0@sinodun.com> Message-ID: On Wed, Feb 12, 2014 at 12:12 PM, Sara Dickinson wrote: > > > - https://github.com/orgs/opendnssec/teams/opendnssec-release-managers > > The page doesn't seem to exist - but the error message is worth seeing :-) > Page works for me. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From sara at sinodun.com Wed Feb 12 11:53:34 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 11:53:34 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> Message-ID: On 11 Feb 2014, at 07:24, Jerry Lundstr?m wrote: > On Mon, Feb 10, 2014 at 4:09 PM, Sara Dickinson wrote: > > I have added a few extra bullet points and heading to the workflow page - please review my changes and make sure they all make sense! > > "however remember that this will mean > they are dependant on each other for being accepted into the upstream repository." > ..that this will they are.. ? :) Fixed. > > Question: Right now who has permission to run what bot commands? > > Should be all of us. Excellent! > > In the beginning I think I hear that the plan is that Jerry/Jakob will run every test on every pull request (not the developer)? Is this right? Will you do this immediately on receiving the request or only after review? How long does this take for the production releases - 2 hours I think for both DBs? > > Currently: > - After review. > - Only smoke. > - Only SQLite. > - 10-20mins. Thank you for clarifying! But - I?m confused. Your previous emails stated: On 23 Jan 2014, at 06:58, Jerry Lundstr?m wrote: > build - Build and run all tests > test - Build and run only the modified tests, if there are no modified tests then run all tests And "The initial plan is to run all test because it was the easiest to get working at first (see ?build? above).? But this contradicts what you wrote above as you list only a subset of tests?. 1) Is it currently possible to run the mysql or daily tests via a bot command? 2) If we follow the above, then it is still possible, in the beginning that code goes into the repo that breaks the MySQL or daily tests - correct? And if that happens developers need to fix it via another pull request? I?m not saying this is the wrong approach to start with - I am just trying to get a clear picture of what you and Jakob have decided and communicate this to the team. > > I can't answer for people but we have the option do allow developers to build and test their feature branch. Doing this does not really remove the requirement to have a separate set of eyes to look at the code. My point is that IMHO the role of the release manager is not to personally do a formal code review (requirements/design/implementation) of each pull request - that should be left to the developers - rather it is make sure the right people have reviewed it, do a sanity check of the code and do the mechanics of running the tests/merge. Do people agree with this? Sara. From jakob at kirei.se Wed Feb 12 11:56:32 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Wed, 12 Feb 2014 12:56:32 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> Message-ID: On 12 feb 2014, at 12:53, Sara Dickinson wrote: > My point is that IMHO the role of the release manager is not to personally do a formal code review (requirements/design/implementation) of each pull request - that should be left to the developers - rather it is make sure the right people have reviewed it, do a sanity check of the code and do the mechanics of running the tests/merge. Do people agree with this? Yes, but the pull request must then contain a note from the reviewer IMHO. jakob From jerry at opendnssec.org Wed Feb 12 12:36:41 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 12 Feb 2014 13:36:41 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> Message-ID: <-3923814766870539982@unknownmsgid> On 12 feb 2014, at 12:50, Sara Dickinson wrote: But - I'm confused. Your previous emails stated: On 23 Jan 2014, at 06:58, Jerry Lundstr?m wrote: build - Build and run all tests test - Build and run only the modified tests, if there are no modified tests then run all tests And "The initial plan is to run all test because it was the easiest to get working at first (see "build" above)." But this contradicts what you wrote above as you list only a subset of tests.... What I meant is that we run the tests we run today when someone has committed (smoke). 1) Is it currently possible to run the mysql or daily tests via a bot command? Not currently. 2) If we follow the above, then it is still possible, in the beginning that code goes into the repo that breaks the MySQL or daily tests - correct? And if that happens developers need to fix it via another pull request? Yes in the beginning. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Wed Feb 12 12:37:43 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 12 Feb 2014 13:37:43 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> Message-ID: <-6938558437652899604@unknownmsgid> On 12 feb 2014, at 12:56, Jakob Schlyter wrote: On 12 feb 2014, at 12:53, Sara Dickinson wrote: My point is that IMHO the role of the release manager is not to personally do a formal code review (requirements/design/implementation) of each pull request - that should be left to the developers - rather it is make sure the right people have reviewed it, do a sanity check of the code and do the mechanics of running the tests/merge. Do people agree with this? Yes, but the pull request must then contain a note from the reviewer IMHO. +1 -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Wed Feb 12 12:40:43 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 12 Feb 2014 13:40:43 +0100 Subject: [Opendnssec-develop] New prel OpenDNSSEC GitHub repository Message-ID: <-1245787345112568114@unknownmsgid> Hi, I'm testing the convert and made a new prel repo, please clone it and check on it some. https://github.com/opendnssec/opendnssec-prel -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From sara at sinodun.com Wed Feb 12 13:02:07 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 13:02:07 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> Message-ID: <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> On 12 Feb 2014, at 11:56, Jakob Schlyter wrote: > On 12 feb 2014, at 12:53, Sara Dickinson wrote: > >> My point is that IMHO the role of the release manager is not to personally do a formal code review (requirements/design/implementation) of each pull request - that should be left to the developers - rather it is make sure the right people have reviewed it, do a sanity check of the code and do the mechanics of running the tests/merge. Do people agree with this? > > Yes, but the pull request must then contain a note from the reviewer IMHO. > Absolutely, it should have a clear note from the developer if they want it reviewed before being accepted, and clear responses from reviewers. One thing I like about Crucible is that it lets you assign reviewer/moderator roles to people and then each one can easily indicate if they have accepted the review or not. I don?t see anything like this in the github review pages? I do see an ?assignee? field but I?m not sure if this could be used to assign a pull request to a reviewer who could then assign it back to the release manager when they are done? Sara. From jakob at kirei.se Wed Feb 12 13:01:42 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Wed, 12 Feb 2014 14:01:42 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> Message-ID: On 12 feb 2014, at 14:02, Sara Dickinson wrote: > Absolutely, it should have a clear note from the developer if they want it reviewed before being accepted, and clear responses from reviewers. I suggest we do not merge any code without 3rd party review. jakob From jerry at opendnssec.org Wed Feb 12 13:04:57 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 12 Feb 2014 14:04:57 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> Message-ID: <8452934941042017995@unknownmsgid> On 12 feb 2014, at 13:59, Sara Dickinson wrote: I do see an 'assignee' field but I'm not sure if this could be used to assign a pull request to a reviewer who could then assign it back to the release manager when they are done? Yes. Used like that in SoftHSMv2. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From sara at sinodun.com Wed Feb 12 13:20:14 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 13:20:14 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: <-3923814766870539982@unknownmsgid> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <-3923814766870539982@unknownmsgid> Message-ID: <6480982F-7C56-48A2-AB1C-4765125B9344@sinodun.com> On 12 Feb 2014, at 12:36, Jerry Lundstr?m wrote: > > What I meant is that we run the tests we run today when someone has committed (smoke). OK - I see now?... > >> 1) Is it currently possible to run the mysql or daily tests via a bot command? > > Not currently. I would like to see both these options added asap, particularly the daily tests. For example, if I modify a daily test this can?t be tested before the pull request is accepted. And if I break a daily test there is no way to test a fix in a follow up pull request - right? Sara. From jerry at opendnssec.org Wed Feb 12 13:22:49 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 12 Feb 2014 14:22:49 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <6480982F-7C56-48A2-AB1C-4765125B9344@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <-3923814766870539982@unknownmsgid> <6480982F-7C56-48A2-AB1C-4765125B9344@sinodun.com> Message-ID: <673916920313683415@unknownmsgid> On 12 feb 2014, at 14:17, Sara Dickinson wrote: I would like to see both these options added asap, particularly the daily tests. For example, if I modify a daily test this can't be tested before the pull request is accepted. And if I break a daily test there is no way to test a fix in a follow up pull request - right? Well you can (and always should) run the test locally yourself. There will be many things added asap including that. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From sara at sinodun.com Wed Feb 12 13:29:38 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 13:29:38 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: <8452934941042017995@unknownmsgid> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> <8452934941042017995@unknownmsgid> Message-ID: <28299412-7D85-4170-A0EE-B15B12CA74F0@sinodun.com> On 12 Feb 2014, at 13:04, Jerry Lundstr?m wrote: > On 12 feb 2014, at 13:59, Sara Dickinson wrote: > >> I do see an ?assignee? field but I?m not sure if this could be used to assign a pull request to a reviewer who could then assign it back to the release manager when they are done? > > Yes. Used like that in SoftHSMv2. And the reason we are not planning to do that in OpenDNSSEC from the beginning is?? From sara at sinodun.com Wed Feb 12 13:31:26 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 13:31:26 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> Message-ID: <7C708B9C-E447-4BE1-A2F7-57D9F2572437@sinodun.com> On 12 Feb 2014, at 13:01, Jakob Schlyter wrote: > On 12 feb 2014, at 14:02, Sara Dickinson wrote: > >> Absolutely, it should have a clear note from the developer if they want it reviewed before being accepted, and clear responses from reviewers. > > I suggest we do not merge any code without 3rd party review. > > jakob > Hmm? that is a big change we haven?t discussed before. How about I add an agenda item to the workshop for us to hammer out if/how we will do this once we all have a couple of weeks of git experience? Sara. From jerry at opendnssec.org Wed Feb 12 13:32:16 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 12 Feb 2014 14:32:16 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <28299412-7D85-4170-A0EE-B15B12CA74F0@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> <8452934941042017995@unknownmsgid> <28299412-7D85-4170-A0EE-B15B12CA74F0@sinodun.com> Message-ID: <4258424472974788563@unknownmsgid> > On 12 feb 2014, at 14:26, Sara Dickinson wrote: > > And the reason we are not planning to do that in OpenDNSSEC from the beginning is...? Noone have said that. Think I actually suggested it at sometime or at least mentioned it. /Jerry From jakob at kirei.se Wed Feb 12 13:50:35 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Wed, 12 Feb 2014 14:50:35 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <7C708B9C-E447-4BE1-A2F7-57D9F2572437@sinodun.com> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> <7C708B9C-E447-4BE1-A2F7-57D9F2572437@sinodun.com> Message-ID: On 12 feb 2014, at 14:31, Sara Dickinson wrote: > Hmm? that is a big change we haven?t discussed before. How about I add an agenda item to the workshop for us to hammer out if/how we will do this once we all have a couple of weeks of git experience? As a compromise until we have proper code review, can we at least state (in the pull request) that no review has been done nor is being requested? That would be like saying "I believe I'm invincible and I don't need no code review from anyone" :-) jakob From sara at sinodun.com Wed Feb 12 17:26:44 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 17:26:44 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: <4258424472974788563@unknownmsgid> References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> <8452934941042017995@unknownmsgid> <28299412-7D85-4170-A0EE-B15B12CA74F0@sinodun.com> <4258424472974788563@unknownmsgid> Message-ID: <1ED7D83F-1399-4FF5-8617-A6660D7D8500@sinodun.com> On 12 Feb 2014, at 13:32, Jerry Lundstr?m wrote: >> On 12 feb 2014, at 14:26, Sara Dickinson wrote: >> >> And the reason we are not planning to do that in OpenDNSSEC from the beginning is...? > > Noone have said that. Think I actually suggested it at sometime or at > least mentioned it. > I remember I asked assigning reviewers at this at the last dev workshop, but I don?t think we knew the answer at the time? But it sounds great - lets do this! Sara. From sara at sinodun.com Wed Feb 12 17:53:04 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 12 Feb 2014 17:53:04 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <52EB9D81.6020306@nlnetlabs.nl> <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> <7C708B9C-E447-4BE1-A2F7-57D9F2572437@sinodun.com> Message-ID: On 12 Feb 2014, at 13:50, Jakob Schlyter wrote: > On 12 feb 2014, at 14:31, Sara Dickinson wrote: > >> Hmm? that is a big change we haven?t discussed before. How about I add an agenda item to the workshop for us to hammer out if/how we will do this once we all have a couple of weeks of git experience? > > As a compromise until we have proper code review, can we at least state (in the pull request) that no review has been done nor is being requested? Sounds reasonable. For a case of something like a lone typo/change to log message/truly trivial fix/regression test fix in a pull request then yes - the developer should spell this out in the pull request comment. Plus, the release manager has discretion to request a review in all cases before accepting anything! We will already be going from 1 to at least 2 pairs of eyes on every commit overnight :-) > That would be like saying "I believe I'm invincible and I don't need no code review from anyone" :-) Well - we all pretty much _think_ that anyway, don?t we? In fact, that would make a good t-shirt ;-) Sara. From rickard at opendnssec.org Thu Feb 13 05:35:54 2014 From: rickard at opendnssec.org (Rickard Bellgrim) Date: Thu, 13 Feb 2014 06:35:54 +0100 Subject: [Opendnssec-develop] Release SoftHSM 1.3.6 Message-ID: Hi We are ready push out a new release of SoftHSMv1. There are no open bug reports or similar. Just waiting for this pull request to update the NEWS file with all of the changes since the previous release. https://github.com/opendnssec/SoftHSMv1/pull/8 // Rickard -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Thu Feb 13 06:22:09 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 13 Feb 2014 07:22:09 +0100 Subject: [Opendnssec-develop] Release SoftHSM 1.3.6 In-Reply-To: References: Message-ID: On Thu, Feb 13, 2014 at 6:35 AM, Rickard Bellgrim wrote: > > We are ready push out a new release of SoftHSMv1. There are no open bug > reports or similar. Just waiting for this pull request to update the NEWS > file with all of the changes since the previous release. > > https://github.com/opendnssec/SoftHSMv1/pull/8 > Ok, I'm on it. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthijs at nlnetlabs.nl Thu Feb 13 07:35:16 2014 From: matthijs at nlnetlabs.nl (Matthijs Mekking) Date: Thu, 13 Feb 2014 08:35:16 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> <9D1DF9AD-EB92-43DF-A66B-443762221854@kirei.se> <7C8D2ECD-F1DD-4451-82FC-64A5AB06D0E0@sinodun.com> Message-ID: <52FC75B4.8000606@nlnetlabs.nl> On 02/12/2014 12:17 PM, Jerry Lundstr?m wrote: > On Wed, Feb 12, 2014 at 12:12 PM, Sara Dickinson > wrote: > > > > - https://github.com/orgs/opendnssec/teams/opendnssec-release-managers > > The page doesn?t seem to exist - but the error message is worth > seeing :-) > > > Page works for me. Still 404 for me. I knew about this nice error message, although it never occurred to me that it also moved when moving with your mouse. > > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ > > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop > From jakob at kirei.se Thu Feb 13 07:39:22 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Thu, 13 Feb 2014 08:39:22 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <52FC75B4.8000606@nlnetlabs.nl> References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> <9D1DF9AD-EB92-43DF-A66B-443762221854@kirei.se> <7C8D2ECD-F1DD-4451-82FC-64A5AB06D0E0@sinodun.com> <52FC75B4.8000606@nlnetlabs.nl> Message-ID: <362597F6-FCF9-482B-8B86-B624B21B69C8@kirei.se> On 13 feb 2014, at 08:35, Matthijs Mekking wrote: > On 02/12/2014 12:17 PM, Jerry Lundstr?m wrote: >> On Wed, Feb 12, 2014 at 12:12 PM, Sara Dickinson > > wrote: >> >> >>> - https://github.com/orgs/opendnssec/teams/opendnssec-release-managers >> >> The page doesn?t seem to exist - but the error message is worth >> seeing :-) >> >> >> Page works for me. > > Still 404 for me. I knew about this nice error message, although it > never occurred to me that it also moved when moving with your mouse. You cannot look at groups of which you are not a member. To summarize: opendssec-release-managers; Jerry & Jakob opendnssec-release-override; Patrik, Sara, Matthijs, Yuri For now, both groups will have push access to the main OpenDNSSEC repo. For SoftHSM, only release managers has push access for now. jakob From yuri at nlnetlabs.nl Thu Feb 13 09:49:53 2014 From: yuri at nlnetlabs.nl (Yuri Schaeffer) Date: Thu, 13 Feb 2014 10:49:53 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <1928406011.5184.1391503581035.JavaMail.mobile-sync@vcgl9> <6600034756208105568@unknownmsgid> <52F0B769.7060303@nlnetlabs.nl> <52F0C34C.9040509@nlnetlabs.nl> <52F11132.20709@nlnetlabs.nl> <629B8806-421D-412F-B038-04FD8A7BDF75@sinodun.com> <7181277E-C6C9-4515-A0F3-B4D2A502C8F5@sinodun.com> <884D02EF-7830-4D1E-9C54-D7BD85A2AC8C@sinodun.com> <7C708B9C-E447-4BE1-A2F7-57D9F2572437@sinodun.com> Message-ID: <52FC9541.2090907@nlnetlabs.nl> >> That would be like saying "I believe I'm invincible and I don't need no code review from anyone" :-) > Well - we all pretty much _think_ that anyway, don?t we? In fact, that would make a good t-shirt ;-) May is suggest that that magic string in the pull request not only get pulled automatically but also that the bot uploads a tarball to the site and make a release announcement? ;) -- Composed on an actual keyboard: all typos genuine. From jerry at opendnssec.org Thu Feb 13 10:31:12 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 13 Feb 2014 11:31:12 +0100 Subject: [Opendnssec-develop] Release SoftHSM 1.3.6 In-Reply-To: References: Message-ID: Hi, SoftHSM 1.3.6rc1 tagged and tar-balled. https://dist.opendnssec.org/source/testing/softhsm-1.3.6rc1.tar.gz https://dist.opendnssec.org/source/testing/softhsm-1.3.6rc1.tar.gz.sig SHA1: 385ca7cc59004b2cc9bee0280daa22854e3af540 SHA256: e23f8e31dab27cf760bc3c9b3417c4c9427156454a9904c996677605e94ed8f3 Someone else please make the release announce, update wiki and Jira. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Thu Feb 13 13:13:40 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 13 Feb 2014 14:13:40 +0100 Subject: [Opendnssec-develop] The move to GitHub - la importancia! Message-ID: Hi all, I would like to prepare for the move later today so everything is ready by the time we have the meeting tomorrow. I would like to stop all jobs in Jenkins tonight and lock the SVN repository (read only) and start the conversion since it take about an hour and if it fails during the night I still have time to fix stuff before to meeting tomorrow. How about around 20:00 CET? Yell if not. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From sara at sinodun.com Thu Feb 13 16:07:58 2014 From: sara at sinodun.com (Sara Dickinson) Date: Thu, 13 Feb 2014 16:07:58 +0000 Subject: [Opendnssec-develop] RE: Team meeting - Friday 14 Feb @ 11:00 CET Message-ID: <2A230340-0B59-4A68-AC85-BA5CCF504BC5@sinodun.com> Hi All, We have a team meeting tomorrow morning to coincide with the move to git. Date: Friday 14 Feb 2014 Time: 11:00-12:00 CET, 10:00-11:00 GMT, 18:00-19:00 CST, 10:00-11:00 UTC Method: Teamspeak (https://wiki.opendnssec.org/display/OpenDNSSEC/Conference+call+details) Agenda: https://wiki.opendnssec.org/display/OpenDNSSEC/2014-02-14+Agenda Regards Sara. From sara at sinodun.com Thu Feb 13 16:41:58 2014 From: sara at sinodun.com (Sara Dickinson) Date: Thu, 13 Feb 2014 16:41:58 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> Message-ID: On 11 Feb 2014, at 07:34, Jerry Lundstr?m wrote: > https://wiki.opendnssec.org/display/OpenDNSSEC/Issue+tracking+process > https://wiki.opendnssec.org/display/OpenDNSSEC/Code+Review+process First pass updates done, will do more once we know what we do!! From sara at sinodun.com Thu Feb 13 16:43:26 2014 From: sara at sinodun.com (Sara Dickinson) Date: Thu, 13 Feb 2014 16:43:26 +0000 Subject: [Opendnssec-develop] Release SoftHSM 1.3.6 In-Reply-To: References: Message-ID: I can do this tomorrow Sara. On 13 Feb 2014, at 10:31, Jerry Lundstr?m wrote: > Hi, > > SoftHSM 1.3.6rc1 tagged and tar-balled. > > https://dist.opendnssec.org/source/testing/softhsm-1.3.6rc1.tar.gz > https://dist.opendnssec.org/source/testing/softhsm-1.3.6rc1.tar.gz.sig > SHA1: 385ca7cc59004b2cc9bee0280daa22854e3af540 > SHA256: e23f8e31dab27cf760bc3c9b3417c4c9427156454a9904c996677605e94ed8f3 > > Someone else please make the release announce, update wiki and Jira. > > -- > Jerry Lundstr?m - OpenDNSSEC Developer > http://www.opendnssec.org/ > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop From jerry at opendnssec.org Thu Feb 13 20:07:08 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 13 Feb 2014 21:07:08 +0100 Subject: [Opendnssec-develop] Re: The move to GitHub - la importancia! In-Reply-To: References: Message-ID: On Thu, Feb 13, 2014 at 2:13 PM, Jerry Lundstr?m wrote: > > I would like to stop all jobs in Jenkins tonight and lock the SVN > repository (read only) and start the conversion since it take about an hour > and if it fails during the night I still have time to fix stuff before to > meeting tomorrow. > SVN is now read only for everyone. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Thu Feb 13 21:05:30 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Thu, 13 Feb 2014 22:05:30 +0100 Subject: [Opendnssec-develop] Re: The move to GitHub - la importancia! In-Reply-To: References: Message-ID: Conversion complete. The final repository can be found at https://github.com/opendnssec/opendnssec , please take a look. An unmodified, straight out of the conversion, repository can be found at https://github.com/opendnssec/opendnssec-svn . -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 14 06:17:28 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 14 Feb 2014 07:17:28 +0100 Subject: [Opendnssec-develop] RE: Move to git In-Reply-To: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> Message-ID: On Mon, Feb 10, 2014 at 4:19 PM, Sara Dickinson wrote: > > 2) From what I understand the svn trunk/OpenDNSSEC will form the basis of > the new OpenDNSSEC git repo. Can we clarify what happens to the two > remaining top level directories in the svn repo under trunk > > trunk/testing > Now available at https://github.com/opendnssec/testing . > trunk/utils > Do we really need this? It only holds m4's and I think we can manage them in the main repository. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 14 08:39:19 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 14 Feb 2014 09:39:19 +0100 Subject: [Opendnssec-develop] Removal of old test platforms Message-ID: Hi, I would like to remove the old platforms today, these would be: centos32-ods13 freebsd32-ods15 openbsd64-ods10 opensuse32-ods14 suse64-ods11 ubuntu12-amd64-ods03 ubuntu32-ods12 The new Red Hat is not up yet, there is issues getting a new activation key so it will take some time. Therefor the old Red Hat is kept. Yell if this is a problem. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Fri Feb 14 10:58:29 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 14 Feb 2014 11:58:29 +0100 Subject: [Opendnssec-develop] Re: The move to GitHub - la importancia! In-Reply-To: References: Message-ID: <280AB403-9AFC-4E89-A04D-2B5DDE700966@opendnssec.org> Hi, Shutting down all jobs in Jenkins now, turning of the build bot, shutting down the old test platforms and starting setting it all up for Git. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Fri Feb 14 11:10:02 2014 From: sara at sinodun.com (Sara Dickinson) Date: Fri, 14 Feb 2014 11:10:02 +0000 Subject: [Opendnssec-develop] Move to git In-Reply-To: References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> Message-ID: <620BF554-9AF1-4ABE-B578-418A94662EB6@sinodun.com> On 14 Feb 2014, at 06:17, Jerry Lundstr?m wrote: > > Now available at https://github.com/opendnssec/testing . The README needs updating as it still refers to svn: https://github.com/opendnssec/testing/blob/master/framework/README > > trunk/utils > > Do we really need this? It only holds m4's and I think we can manage them in the main repository. > I don?t know the history of why this top level dir was used?. But that seems reasonable. Anyone else have a view? Sara. From jakob at kirei.se Fri Feb 14 11:37:38 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Fri, 14 Feb 2014 12:37:38 +0100 Subject: [Opendnssec-develop] Move to git In-Reply-To: <620BF554-9AF1-4ABE-B578-418A94662EB6@sinodun.com> References: <8F9CE9CC-DED5-4827-BDFA-A9B74A3CCBAE@sinodun.com> <620BF554-9AF1-4ABE-B578-418A94662EB6@sinodun.com> Message-ID: On 14 feb 2014, at 12:10, Sara Dickinson wrote: > I don?t know the history of why this top level dir was used?. But that seems reasonable. Anyone else have a view? It was used when we tried to sync the M4 between the different sub projects. Scrap it. jakob From sara at sinodun.com Fri Feb 14 11:44:43 2014 From: sara at sinodun.com (Sara Dickinson) Date: Fri, 14 Feb 2014 11:44:43 +0000 Subject: Fwd: [Opendnssec-develop] Team meeting - Friday 14 Feb @ 11:00 CET References: <2A230340-0B59-4A68-AC85-BA5CCF504BC5@sinodun.com> Message-ID: Hi All, The minutes from the meeting today are available for review: https://wiki.opendnssec.org/display/OpenDNSSEC/2014-02-14+Minutes We meet for the developer workshop 27/28th Feb and then the next team meeting is scheduled for: Date: Thursday 20 Mar 2014 Time: 14:00-15:00 CET, 13:00-14:00 GMT, 21:00-22:00 CST, 13:00-14:00 UTC Sara. -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenDNSSEC team meeting.ics Type: text/calendar Size: 715 bytes Desc: not available URL: -------------- next part -------------- Begin forwarded message: > From: Sara Dickinson > Subject: [Opendnssec-develop] RE: Team meeting - Friday 14 Feb @ 11:00 CET > Date: 13 February 2014 16:07:58 GMT > To: Opd Dev > > Hi All, > > We have a team meeting tomorrow morning to coincide with the move to git. > > Date: Friday 14 Feb 2014 > Time: 11:00-12:00 CET, 10:00-11:00 GMT, 18:00-19:00 CST, 10:00-11:00 UTC > Method: Teamspeak (https://wiki.opendnssec.org/display/OpenDNSSEC/Conference+call+details) > Agenda: https://wiki.opendnssec.org/display/OpenDNSSEC/2014-02-14+Agenda > > > Regards > > Sara. > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop From jakob at kirei.se Fri Feb 14 13:24:49 2014 From: jakob at kirei.se (Jakob Schlyter) Date: Fri, 14 Feb 2014 14:24:49 +0100 Subject: [Opendnssec-develop] commit mails from github Message-ID: <91440B53-AE9B-4CC9-B254-235659531031@kirei.se> Commit mails for the OpenDNSSEC repo from github should now be running (test mail already sent). jakob From sara at sinodun.com Fri Feb 14 14:25:50 2014 From: sara at sinodun.com (Sara Dickinson) Date: Fri, 14 Feb 2014 14:25:50 +0000 Subject: [Opendnssec-develop] SoftHSM 1.3.6rc1 release candidate Message-ID: <773B1F35-049E-4587-B7E6-240A0E2616AA@sinodun.com> All, Version 1.3.6rc1 of SoftHSM is now available. This is a release candidate for testing purposes: SoftHSM 1.3.6rc1 ------------------------ Updates: * SOFTHSM-51: Call umask to restrict created files. Bugfixes: * Fix malloc(0) warning in clang. Download: * https://dist.opendnssec.org/source/testing/softhsm-1.3.6rc1.tar.gz * https://dist.opendnssec.org/source/testing/softhsm-1.3.6rc1.tar.gz.sig * Checksum sha1: 385ca7cc59004b2cc9bee0280daa22854e3af540 * Checksum sha256: e23f8e31dab27cf760bc3c9b3417c4c9427156454a9904c996677605e94ed8f3 A full SoftHSM 1.3.6 release is planned for Friday 20th February. //OpenDNSSEC team From jerry at opendnssec.org Fri Feb 14 16:16:09 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 14 Feb 2014 17:16:09 +0100 Subject: [Opendnssec-develop] Re: The move to GitHub - la importancia! In-Reply-To: <280AB403-9AFC-4E89-A04D-2B5DDE700966@opendnssec.org> References: <280AB403-9AFC-4E89-A04D-2B5DDE700966@opendnssec.org> Message-ID: Hi, Most things are done and Jenkins jobs are crunching away. Some changes/issues: - trunk-mysql jobs have been removed - 1.3/1.3-mysql/1.4/1.4-mysql/trunk jobs are not triggered by SCM changes, will be fixed next week - Old test platform nodes removed - Solaris removed from all jobs - Sandbox jobs have not been update, can?t we just remove them now anyway? - Build bot is running and people should all have access to #build. 1.3 and trunk has been tested and everything works with Git, all other will be scheduled so we can see the result next week. Jakob made the first pull request and its building on happily https://github.com/opendnssec/opendnssec/pull/1 https://jenkins.opendnssec.org/job/pull-opendnssec-1-fetch/1/downstreambuildview/ . I?m off for the weekend now, cheers, stay safe and pull request! -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Mon Feb 17 11:49:18 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 17 Feb 2014 12:49:18 +0100 Subject: [Opendnssec-develop] Continuing working on old SVN feature branches Message-ID: <5CCD25AD-0595-4250-8EDD-A59B19BD45A7@opendnssec.org> Hi, Here is how you can continue working on the SVN branches, this example uses Yuri?s reload work branch and should work with all the other branches also. # Fork opendnssec on GitHub git clone git at github.com:/opendnssec.git cd opendnssec git remote add svn https://github.com/opendnssec/opendnssec-svn.git git fetch svn git checkout -b svn/OpenDNSSEC-reload-rework reload-rework git push -u origin reload-work You now have a ?reload-work? branch locally and on your OpenDNSSEC fork. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Mon Feb 17 14:24:57 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 17 Feb 2014 15:24:57 +0100 Subject: [Opendnssec-develop] Re: Continuing working on old SVN feature branches In-Reply-To: <5CCD25AD-0595-4250-8EDD-A59B19BD45A7@opendnssec.org> References: <5CCD25AD-0595-4250-8EDD-A59B19BD45A7@opendnssec.org> Message-ID: On 17 Feb 2014, at 12:49 , Jerry Lundstr?m wrote: > # Fork opendnssec on GitHub > git clone git at github.com:/opendnssec.git > cd opendnssec > git remote add svn https://github.com/opendnssec/opendnssec-svn.git > git fetch svn > git checkout -b svn/OpenDNSSEC-reload-rework reload-rework Above should be: git checkout -b reload-rework svn/OpenDNSSEC-reload-rework > git push -u origin reload-work -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Tue Feb 18 06:51:02 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 18 Feb 2014 07:51:02 +0100 Subject: [Opendnssec-develop] Jenkins jobs disabled // Update of test platforms Message-ID: Hi, Doing some maintenance work on test platforms, all Jenkins jobs are disabled during the work. Everything will shortly be back up. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Tue Feb 18 07:02:59 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Tue, 18 Feb 2014 08:02:59 +0100 Subject: [Opendnssec-develop] Re: Jenkins jobs disabled // Update of test platforms In-Reply-To: References: Message-ID: On Tue, Feb 18, 2014 at 7:51 AM, Jerry Lundstr?m wrote: > > Doing some maintenance work on test platforms, all Jenkins jobs are > disabled during the work. Everything will shortly be back up. > All done and Jenkins jobs are enabled again. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Wed Feb 19 09:03:42 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 19 Feb 2014 10:03:42 +0100 Subject: [Opendnssec-develop] Out of office Thursday 20/2 Message-ID: <-2752285820580425615@unknownmsgid> Won't be reachable, back Friday. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jerry at opendnssec.org Wed Feb 19 12:51:56 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 19 Feb 2014 13:51:56 +0100 Subject: [Opendnssec-develop] New TeamSpeak server for meetings Message-ID: <5BE9B4B9-AD69-41FC-AD2B-8AEB3AD47D3C@opendnssec.org> https://wiki.opendnssec.org/display/OpenDNSSEC/Conference+call+details -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Wed Feb 19 13:29:52 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 19 Feb 2014 14:29:52 +0100 Subject: [Opendnssec-develop] Reinstallation of titan.opendnssec.org Message-ID: <7C6CFBD0-8D33-4E2B-BFEA-3EA6BF74AD8E@opendnssec.org> Hi, I would like to plan an reinstallation of titan to get it under the control of dasbot for easier management. This is depended on getting Red Hat licenses so it will not start before the current issues with that are solved. People with locally stored stuff should start moving it, backing it up or adding it into the SCM soon. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Wed Feb 19 14:17:40 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 19 Feb 2014 14:17:40 +0000 Subject: [Opendnssec-develop] Re: Reinstallation of titan.opendnssec.org In-Reply-To: <7C6CFBD0-8D33-4E2B-BFEA-3EA6BF74AD8E@opendnssec.org> References: <7C6CFBD0-8D33-4E2B-BFEA-3EA6BF74AD8E@opendnssec.org> Message-ID: On 19 Feb 2014, at 13:29, Jerry Lundstr?m wrote: > Hi, > > I would like to plan an reinstallation of titan to get it under the control of dasbot for easier management. > > This is depended on getting Red Hat licenses so it will not start before the current issues with that are solved. > > People with locally stored stuff should start moving it, backing it up or adding it into the SCM soon. Hi Jerry, I?m actively using it to re-benchmark some code fixes so please let me know possible re-install dates asap :-) Sara. From jerry at opendnssec.org Fri Feb 21 09:14:22 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 21 Feb 2014 10:14:22 +0100 Subject: [Opendnssec-develop] Re: New TeamSpeak server for meetings In-Reply-To: <5BE9B4B9-AD69-41FC-AD2B-8AEB3AD47D3C@opendnssec.org> References: <5BE9B4B9-AD69-41FC-AD2B-8AEB3AD47D3C@opendnssec.org> Message-ID: On 19 Feb 2014, at 13:51 , Jerry Lundstr?m wrote: > https://wiki.opendnssec.org/display/OpenDNSSEC/Conference+call+details Appears that the firewall at .SE needs some tweaking so it might take a few days before its working. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From sara at sinodun.com Mon Feb 24 12:01:56 2014 From: sara at sinodun.com (Sara Dickinson) Date: Mon, 24 Feb 2014 12:01:56 +0000 Subject: [Opendnssec-develop] SoftHSM 1.3.6 Message-ID: <99F40389-44AB-4252-AAFC-5A1750B7153E@sinodun.com> All, Version 1.3.6 of SoftHSM has now been released. This is the latest stable release. Updates: * SOFTHSM-51: Call umask to restrict created files. Bugfixes: * Fix malloc(0) warning in clang. Documentation: * https://wiki.opendnssec.org/display/SoftHSMDOCS/SoftHSM+Documentation+v1.3 Download: * https://dist.opendnssec.org/source/softhsm-1.3.6.tar.gz * https://dist.opendnssec.org/source/softhsm-1.3.6.tar.gz.sig * Checksum sha1: 442f94d681006b16b8d2630d2e58849cb804463d * Checksum sha256: e39ac8e851220edd2b2afbe4d9e06d956bccc20bc72752740eabf95692359486 //OpenDNSSEC team From jerry at opendnssec.org Mon Feb 24 13:20:07 2014 From: jerry at opendnssec.org (=?iso-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Mon, 24 Feb 2014 14:20:07 +0100 Subject: [Opendnssec-develop] Removal of redhat64-ods08 and the bind tests Message-ID: <4FBC1A64-67DE-404F-965A-16D099F170FA@opendnssec.org> Hi, I am about to disable the bind tests in order to remove redhat64-ods08 and start using the new redhat6-ods04. If you have something on redhat64-ods08 that needs saving please tell me ASAP because that VM will be reused in the future, for now it will be left online. The bind tests will be reactivated later when I have setup all the platforms with bind so this can run everywhere. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 625 bytes Desc: Message signed with OpenPGP using GPGMail URL: From jerry at opendnssec.org Wed Feb 26 06:39:34 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Wed, 26 Feb 2014 07:39:34 +0100 Subject: [Opendnssec-develop] Re: Dasbot, buildfarm & Jenkins In-Reply-To: References: Message-ID: On Wed, Jan 22, 2014 at 7:50 AM, Jerry Lundstr?m wrote: > > With the new bot I will also make some changes to Jenkins, the LDNS and > SoftHSM build jobs that OpenDNSSEC depends on will be removed and that type > of dependency will be installed and managed by the bot. > > This will reduce the overhead for OpenDNSSEC jobs, reduce the complexity > and greatly reduce the overhead for pull request builds since they do build > LDNS and SoftHSM for each pull request as that is our current build chain. > LDNS is now installed with dasbot, the LDNS Jenkins jobs have been removed and all other jobs now uses the custom installed LDNS. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From sara at sinodun.com Wed Feb 26 13:47:08 2014 From: sara at sinodun.com (Sara Dickinson) Date: Wed, 26 Feb 2014 13:47:08 +0000 Subject: Fwd: [Opendnssec-develop] Developer workshop References: Message-ID: <14159306-9BCC-462C-B59A-20FD525D4090@sinodun.com> Hi All, Just updated the wiki page below with times for the workshop. Plan is to start at 9am tomorrow. Also added a couple of options for dinner. See you tomorrow. Sara. Begin forwarded message: > From: Sara Dickinson > Subject: [Opendnssec-develop] RE: Developer workshop > Date: 11 February 2014 11:54:09 GMT > To: Opd Dev > > HI All, > > Here is a provisional agenda for the workshop - please let me know if you would like to add/change anything. > > https://wiki.opendnssec.org/display/OpenDNSSEC/Developer+workshop+-+London+Feb+2014 > > I?m waiting for final confirmation the office site is booked, but this should be a formality. > > Also - if you have any dietary requirements, please let me know asap. > > Sara. > > _______________________________________________ > Opendnssec-develop mailing list > Opendnssec-develop at lists.opendnssec.org > https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop From jerry at opendnssec.org Fri Feb 28 15:58:34 2014 From: jerry at opendnssec.org (=?ISO-8859-1?Q?Jerry_Lundstr=F6m?=) Date: Fri, 28 Feb 2014 16:58:34 +0100 Subject: [Opendnssec-develop] Re: New TeamSpeak server for meetings In-Reply-To: References: <5BE9B4B9-AD69-41FC-AD2B-8AEB3AD47D3C@opendnssec.org> Message-ID: On Fri, Feb 21, 2014 at 10:14 AM, Jerry Lundstr?m wrote: > On 19 Feb 2014, at 13:51 , Jerry Lundstr?m wrote: > > > https://wiki.opendnssec.org/display/OpenDNSSEC/Conference+call+details > > Appears that the firewall at .SE needs some tweaking so it might take a > few days before its working. > The firewall has now been patted on and is very happy, if you have time please test it out. -- Jerry Lundstr?m - OpenDNSSEC Developer http://www.opendnssec.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: