[Opendnssec-develop] Fwd: [issues.opendnssec.org] (OPENDNSSEC-342) Case-sensite comparison in auditor

[Sara Dickinson]

Hi there, 

Good spot Jerry - so there is a difference between what is stated on the wiki page and what (as far as I can tell) has actually been done over the lifetime of ODS as a product.

1) Release process: I believe Rickard put that process page together some time (years) ago - I seem to remember that we looked at it in the developer workshop in 2011 and realised it was wrong. I have a long standing JIRA issue from then to update it (http://issues.opendnssec.org/browse/OPENDNSSEC-121) but it doesn't say what was decided.....? I did also find a discussion of version support at the RIPE 64 board meeting (https://wiki.opendnssec.org/download/attachments/2621467/OAB+meeting+minutes+v1.pdf?version=1&modificationDate=1337869309000) but it seems to only reach a conclusion about what do to with regard to 'support contracts' and in that case the plan is to support the current and the previous major version (I wasn't there but I imagine 1.2, 1.3 and 1.4 were considered 'major' versions in this context?). Anyone else remember anything from either meeting? I think we need to revisit and agree on what the process should be before changing anything....  

Anyhoo - even if we decide to change approach and support 'the current and previous major release' once 1.4 is shipped we would stop support for 1.2 anyway so I'm not sure it would be worth the effort to support it in the short term. I believe the most sensible approach might be to continue to support 1.3 after the release of 1.4 since this should have a relatively low overhead and provide support to the majority of users who I believe are on 1.3.

2) Is this issue with the auditor a show-stopper? The reporter only marked it as minor since I suppose they are using the patch they developed. In general though, I would argue (as we would have with other fixes) users should upgrade to 1.3 for the fix unless they had a show stopping reason not to. 

Sara.


On 23 Oct 2012, at 11:07, Jerry Lundström wrote:

> I think the issue is generic, domain names are case insensitive.
> 
> But regardless of the issue its good if we come to an understanding what we should and should not do.
> 
> Current process says we should so are we to spend time to fix bugs and setup tests or ... should we change the process?
> 
> And dont forget, we still have some "large" users running 1.0.
> 
> /Jerry
> 
> On 23 okt 2012, at 11:49, "Siôn Lloyd" <sion at nominet.org.uk> wrote:
> 
>> This particular issue is not typical... I believe that it affects the auditor only if it is used with a signer other than the ODS signer (in this case BIND).
>> 
>> That said, I think that it is worth having this discussion; but maybe in the context of a "show stopping" bug being found in 1.2.
>> 
>> In that case I think that we should patch it; but we'd need to test it somehow as we do not want to have to run 1.2 on jenkins. Would it be possible to run 1.2 through the tests written for 1.3? I can't remember how much the interface has changed but I suspect that this would be a fair amount of work.
>> 
>> Sion
>> 
>> 
>> On 23/10/12 10:18, Jerry Lundström wrote:
>>> Hi,
>>> 
>>> I forward this to the developer list for discussion.
>>> 
>>> We have it in https://wiki.opendnssec.org/display/OpenDNSSEC/Release+Management+Process to support older versions and it is somewhat confusing since we have been using minor version numbering as major releases.
>>> 
>>> According to current process we today should support 1.2 and 1.1 but if that feasible?
>>> 
>>> /Jerry
>>> 
>>> Begin forwarded message:
>>> 
>>>> From: Siôn Lloyd (JIRA) <issues at opendnssec.org>
>>>> Date: 23 oktober 2012 11:03:22 CEST
>>>> To: jerry at opendnssec.org
>>>> Subject: [issues.opendnssec.org] (OPENDNSSEC-342) Case-sensite comparison in auditor
>>>> 
>>>> 
>>>> 
>>>> Siôn Lloyd resolved  OPENDNSSEC-342 as Fixed
>>>> Case-sensite comparison in auditor
>>>> 
>>>> Patched the code in the 1.3 branch (see rev 6758)
>>>> I am going to patch the auditor held in trunk, but should we really be patching 1.2?
>>>> 
>>>> Change By:	Siôn Lloyd (2012-10-23 11:02)
>>>> Status:	Open Resolved
>>>> Assignee:	Alex Dalitz Siôn Lloyd
>>>> Fix Version/s:	1.3.11
>>>> Fix Version/s:	1.2.3
>>>> Resolution:	Fixed
>>>> This message is automatically generated by JIRA.
>>>> If you think it was sent incorrectly, please contact your JIRA administrators.
>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>> 
>>> 
>>> _______________________________________________
>>> Opendnssec-develop mailing list
>>> 
>>> Opendnssec-develop at lists.opendnssec.org
>>> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop
>> 
>> _______________________________________________
>> Opendnssec-develop mailing list
>> Opendnssec-develop at lists.opendnssec.org
>> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop
> _______________________________________________
> Opendnssec-develop mailing list
> Opendnssec-develop at lists.opendnssec.org
> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop