[Opendnssec-develop] Re: [Opendnssec-user]How to speed up signing performance

[Jerry Lundström]

Hi,

On Wed, Nov 21, 2012 at 4:34 PM, Matthijs Mekking <matthijs at nlnetlabs.nl> wrote:
> The cpu patch was incorporated and is already included in the 1.4 beta.
>
> The aggressive retry patch is also applied, with small adjustments:
>
> -        if (status == ODS_STATUS_UNCHANGED) {
> -            worker_wait_timeout_locked(&q->q_lock, &q->q_nonfull, 60);
> +        if (!tries && status == ODS_STATUS_UNCHANGED) {
> +            worker_wait_timeout_locked(&q->q_lock, &q->q_nonfull, 5);
>          }
>
> The waiting should only occur when the number of max tries has been
> reached (tries has been reset to 0). Also, 60 seconds seems indeed a
> long maximum wait, 5 will do too (If the queue is not full, the timeout
> should of course be shorter). This change is for now only in trunk, it
> will be in the 1.4 rc.

I feel that the assumption that 60 seconds is a long time to wait is false.

If the locking/condition/signal code for the workers was working then
you could actually wait forever because it would be signaled when
there is more work.

Seeing that this patch has been introduced then it means that that
code does not work as it should and it could lead to more problems
like dead locks / slow downs and CPU hogging.

-- 
Jerry Lundström - OpenDNSSEC Developer
http://www.opendnssec.org/