[Opendnssec-develop] performance test

Matthijs Mekking matthijs at NLnetLabs.nl
Wed Mar 9 07:36:58 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/08/2011 06:03 PM, Rickard Bellgrim wrote:
> Just to be safe, shouldn't the locks of the queue be handled within the pop and push functions? So that the thread safety is handled by the queue and not someone else.

My school of thought is that the user of the shared element (queue in
this case) should lock and unlock, not the shared element itself.

> 8 mar 2011 kl. 17:42 skrev "Rickard Bellgrim" <rickard.bellgrim at iis.se>:
> 
>>
>> On 8 mar 2011, at 16.33, Rickard Bellgrim wrote:
>>
>>> No performance gain by using multiple threads.

:(

>> Is the queue locked while the drudger is waiting for the condition?

No, the queue is only locked when pushing an item:

http://trac.opendnssec.org/browser/trunk/OpenDNSSEC/signer/src/signer/rrset.c#L1140

and popping an item:

http://trac.opendnssec.org/browser/trunk/OpenDNSSEC/signer/src/daemon/worker.c#L513

>>
>> http://trac.opendnssec.org/browser/trunk/OpenDNSSEC/signer/src/daemon/worker.c#L684
>>
>> // Rickard
>>
> _______________________________________________
> Opendnssec-develop mailing list
> Opendnssec-develop at lists.opendnssec.org
> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNdy4aAAoJEA8yVCPsQCW5lecIAKryTK6R0chwNn8crqUQNVBd
dybRjH9BlRgi3ifTzJWOPBljwHPheRRqhY4gKc5VVGa9r5fiCGzly6dhXwFqmBUv
jEwwSii0aWguBDYzrwq9pQVZzMiOgU9Gk8TCtgwctf37yTJfYaVODg9y3tTn7QXx
peHLHgWKhXESQEOfi7nqY3PHUXyLSfFCTZdaRRM0dr0/iijxwK8PTzYFm1kmB/AL
WCIzC4yKqKd/aASazbAbr+Kk21XC6i/TC84RVUrfdkgS2S8ZRyZ2sqic+BeAXTts
if+6vbVs8bSMk/DkuWWEk5OUgnW81Fav59sj9+BuypnEW99oCETKVgXfBwJvPpw=
=Wo72
-----END PGP SIGNATURE-----



More information about the Opendnssec-develop mailing list