[Opendnssec-develop] Re: [Opendnssec-commits] [keihatsu.kirei.se/svn/dnssec] r5372 - in trunk/OpenDNSSEC/signer/src: shared signer

[Matthijs Mekking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/09/2011 04:37 PM, Rickard Bellgrim wrote:
> On Mon, Aug 8, 2011 at 10:02 AM, Matthijs Mekking <matthijs at nlnetlabs.nl> wrote:
>> Author: matthijs
>> Date: 2011-08-08 10:02:54 +0200 (Mon, 08 Aug 2011)
>> New Revision: 5372
>>
>> Modified:
>>   trunk/OpenDNSSEC/signer/src/shared/hsm.c
>>   trunk/OpenDNSSEC/signer/src/signer/keys.c
>>   trunk/OpenDNSSEC/signer/src/signer/keys.h
>> Log:
>> Pivotal Story #16517425: Signature lifetime too long/short
>> https://www.pivotaltracker.com/story/show/16517425
>>
>> port from branch 1.3
> 
> I am getting errors from this one.
> 
> Aug  9 14:19:20 fou ods-signerd: ../../../signer/src/shared/hsm.c at
> 58 could not pthread_mutex_lock(&key_id->key_lock): Invalid argument
> Aug  9 14:19:20 fou ods-signerd: ../../../signer/src/shared/hsm.c at
> 78 could not pthread_mutex_unlock(&key_id->key_lock): Invalid argument
> Aug  9 14:19:20 fou ods-signerd: ../../../signer/src/shared/hsm.c at
> 112 could not pthread_mutex_lock(&key_id->key_lock): Invalid argument
> Aug  9 14:19:20 fou ods-signerd: ../../../signer/src/shared/hsm.c at
> 114 could not pthread_mutex_unlock(&key_id->key_lock): Invalid
> argument

Strange.

> 
> Another problem is that you now only get a single threaded signer
> since there is a lock for the key. Would it be a solution to have a
> local params in the lhsm_sign and get the non-volatile information
> (owner, algorithm, flags) from the key_id?

Yes, I was afraid for that. I have already changed that locally, will
commit tomorrow.

Best regards,

> 
> // Rickard
> _______________________________________________
> Opendnssec-develop mailing list
> Opendnssec-develop at lists.opendnssec.org
> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOQZ9vAAoJEA8yVCPsQCW5TosH/2UaABtu8/P9LHe6uKM6ERDJ
RGH/Fu7m9Kq1beORVj0Bj+/BkvYxOiCVF3iChJoJEG34rzrEP7DIJDaTKJ9n5KCG
5VdZ9I4uR8J8HDURRWqwQX32qICpb/Xl0fS3Oaop8UHKzrRoydifjyQlD/kKTbY3
8K4NoEVUsfNlC3Cj43BJLv0hJFrwrzTPWsFZj7Vi4X5E2waFBvkPRmpRWeJcG+57
tdE8hTz+XsEYAFpUJpdk4mBQX9tZ9Wi3zH5M5VTgcChhWe/EP6M1X5nP59rgbsdf
+kVs7KQ8MUSJfdC2muLpiLqnCf+Q0tLCjDkJaPeuAiBDsc86haBlrBB1SwWMky4=
=bUvh
-----END PGP SIGNATURE-----