[Opendnssec-develop] ods-control hangs

[Matthijs Mekking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

So ods-control stops hanging after 10 seconds?

Maybe use a bit more shorter period, or give the user feedback of what
is going on...

Best regards,

Matthijs


On 10/01/2010 09:43 AM, Sion Lloyd wrote:
> I've had a second report of this now, is anyone _not_ happy for me to commit 
> this code?
> 
> Sion
> 
> On Wednesday 29 Sep 2010 12:03:01 pm Sion Lloyd wrote:
>> Hi there.
>>
>> I've had this report from Matthijs:
>> http://www.pivotaltracker.com/story/show/5184282
>>
>> Where I think that because ods-control is looking at the return value of
>> the parent process (not the forked one) it sees "success" even when, for
>> instance, the HSM PIN is wrong in conf.xml...
>>
>> My shell scripting is a bit rusty, and I don't have much experience in it
>> to start with. So can someone sanity-check this before I check it in? I
>> just want the start command to timeout. (Sorry about the indenting.)
>>
>> Cheers,
>>
>> Sion
>>
>> sion at sion:~/work/opendnssec/trunk/OpenDNSSEC$ svn diff tools/ods-control.in
>> Index: tools/ods-control.in
>>
> ===================================================================
>> --- tools/ods-control.in        (revision 4024)
>> +++ tools/ods-control.in        (working copy)
>> @@ -62,8 +62,14 @@
>>                         "$sbindir/ods-enforcerd"
>>                         RETVAL=$?
>>                         if [ $RETVAL = 0 ]; then
>> +                i=0
>>                                 while [ ! -r "$enforcer_pid_file" ]; do
>>                                         sleep 1
>> +                    i=$(( $i + 1 ))
>> +                    if [ $i -ge 10 ]; then
>> +                        RETVAL=1
>> +                        break
>> +                    fi
>>                                 done
>>                         fi
>>                 fi
>> _______________________________________________
>> Opendnssec-develop mailing list
>> Opendnssec-develop at lists.opendnssec.org
>> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop
> _______________________________________________
> Opendnssec-develop mailing list
> Opendnssec-develop at lists.opendnssec.org
> https://lists.opendnssec.org/mailman/listinfo/opendnssec-develop
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJMpZNzAAoJEA8yVCPsQCW55MIH/0n8F7b9KV0Aohb8lDLTKniU
6UOV0Pdyh9OMvIS1PhxOhVKXxcIgLlZGpwWoEsTMzGhA/WExOa+k8lNEAT47IbZI
q0kLBGcBXveYvP4/cUqQm4+WbHHKP5hCDD50ogiIipH6e+TfmIc8CzZlhLApWwgO
elj9XOP8orFr7XVLUuM5xz/1vjuN19j/bW2aDWIiNT6i0iW7lkx1dxVvIc5SdYVv
wvIJOSXrGkchdrGO0hNvfOFPfjtHPylGi0EmC/Khv9zjFUjpug55ijRM5p8UVMYP
etxcoq33++xjZ/c1iCm++CK/BRwqiDIKstxlmJb0Q4b63XbZfgc98bX1nENDr0k=
=g9U1
-----END PGP SIGNATURE-----