[Opendnssec-commits] matthijs r7083 - in trunk/OpenDNSSEC/signer/src: . daemon scheduler

commits at svn.opendnssec.org commits at svn.opendnssec.org
Wed Apr 3 15:27:51 CEST 2013


Author: matthijs
Date: Wed Apr  3 15:27:51 2013
New Revision: 7083
URL: http://fisheye.opendnssec.org/changelog/opendnssec?cs=7083

Log:
layout, doc typos, a return warning fix and a fd leak fix.

Modified:
   trunk/OpenDNSSEC/signer/src/daemon/cfg.c
   trunk/OpenDNSSEC/signer/src/ods-signer.c
   trunk/OpenDNSSEC/signer/src/ods-signerd.c
   trunk/OpenDNSSEC/signer/src/scheduler/fifoq.h

Modified: trunk/OpenDNSSEC/signer/src/daemon/cfg.c
==============================================================================
--- trunk/OpenDNSSEC/signer/src/daemon/cfg.c	Wed Apr  3 12:59:17 2013	(r7082)
+++ trunk/OpenDNSSEC/signer/src/daemon/cfg.c	Wed Apr  3 15:27:51 2013	(r7083)
@@ -77,6 +77,7 @@
         if (!ecfg) {
             ods_log_error("[%s] unable to create config: allocator_alloc() "
                 "failed", conf_str);
+            ods_fclose(cfgfd);
             return NULL;
         }
         ecfg->allocator = allocator;

Modified: trunk/OpenDNSSEC/signer/src/ods-signer.c
==============================================================================
--- trunk/OpenDNSSEC/signer/src/ods-signer.c	Wed Apr  3 12:59:17 2013	(r7082)
+++ trunk/OpenDNSSEC/signer/src/ods-signer.c	Wed Apr  3 15:27:51 2013	(r7083)
@@ -64,7 +64,7 @@
     fprintf(out, "Usage: %s [<cmd>]\n", "ods-signer");
     fprintf(out, "Simple command line interface to control the signer "
                  "engine daemon.\nIf no cmd is given, the tool is going "
-                 "to interactive mode.\n");
+                 "into interactive mode.\n");
     fprintf(out, "\nBSD licensed, see LICENSE in source package for "
                  "details.\n");
     fprintf(out, "Version %s. Report bugs to <%s>.\n",
@@ -101,7 +101,6 @@
     fd_set rset;
     char buf[ODS_SE_MAXLINE];
 
-    stdineof = 0;
     FD_ZERO(&rset);
     for(;;) {
         /* prepare */
@@ -202,7 +201,8 @@
                 }
                 /* ret > 0 : when we get here... */
                 if (written+ret > n) {
-                    fprintf(stderr, "\n\nwrite error: more bytes (%d) written than required (%d)\n",
+                    fprintf(stderr, "\n\nwrite error: more bytes (%d) written "
+                        "than required (%d)\n",
                         written+ret, n);
                     break;
                 }
@@ -258,11 +258,12 @@
             ods_writen(sockfd, buf, n);
         }
     }
+    return 0;
 }
 
 
 /**
- * Start interface
+ * Start interface.
  *
  */
 static int

Modified: trunk/OpenDNSSEC/signer/src/ods-signerd.c
==============================================================================
--- trunk/OpenDNSSEC/signer/src/ods-signerd.c	Wed Apr  3 12:59:17 2013	(r7082)
+++ trunk/OpenDNSSEC/signer/src/ods-signerd.c	Wed Apr  3 15:27:51 2013	(r7083)
@@ -83,8 +83,6 @@
 }
 
 
-
-
 /**
  * Main. start engine and run it.
  *

Modified: trunk/OpenDNSSEC/signer/src/scheduler/fifoq.h
==============================================================================
--- trunk/OpenDNSSEC/signer/src/scheduler/fifoq.h	Wed Apr  3 12:59:17 2013	(r7082)
+++ trunk/OpenDNSSEC/signer/src/scheduler/fifoq.h	Wed Apr  3 15:27:51 2013	(r7083)
@@ -80,7 +80,6 @@
 /**
  * Wipe queue.
  * \param[in] q queue to be wiped
- * \param[out] worker worker that owns the item
  *
  */
 void fifoq_wipe(fifoq_type* q);



More information about the Opendnssec-commits mailing list