<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>On 12 feb 2014, at 12:56, Jakob Schlyter <<a href="mailto:jakob@kirei.se">jakob@kirei.se</a>> wrote:<br><br>
</div><blockquote type="cite"><div><span>On 12 feb 2014, at 12:53, Sara Dickinson <<a href="mailto:sara@sinodun.com">sara@sinodun.com</a>> wrote:</span><br><span></span><br><blockquote type="cite"><span>My point is that IMHO the role of the release manager is not to personally do a formal code review (requirements/design/implementation) of each pull request - that should be left to the developers - rather it is make sure the right people have reviewed it, do a sanity check of the code and do the mechanics of running the tests/merge. Do people agree with this?</span><br>
</blockquote><span></span><br><span>Yes, but the pull request must then contain a note from the reviewer IMHO.</span><br></div></blockquote><div><br></div>+1<div><br></div><div><span style="background-color:rgba(255,255,255,0)">-- <br>
Jerry Lundström - OpenDNSSEC Developer<br><a href="http://www.opendnssec.org/" target="_blank">http://www.opendnssec.org/</a></span><br><blockquote type="cite"><div><span></span></div></blockquote></div></body></html>