<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 24/08/12 09:44, Sara (Sinodun)
wrote:<br>
</div>
<blockquote
cite="mid:B59D54B7-7066-4CAB-9F88-2BF5248B7E48@sinodun.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<br>
<div>
<div>On 24 Aug 2012, at 06:42, Jerry Lundström wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div>Hi,<br>
<br>
So yesterday at the telephone conference meeting we
discussed the<br>
multithreaded Enforcer and Sion have tested the
functionality of the<br>
branch and is happy with it. I would now like everyone
comment on the<br>
issues I see that are left to resolve before we merge the
code into<br>
trunk.<br>
<br>
1. Logging<br>
<br>
Today nothing has been made to the logging of the functions
called<br>
when doing work in multiple threads. Without threads the
Enforcer logs<br>
what zone it starts processing and then a few log lines
about the<br>
progress, theses log lines now come all mixed up so you can
not<br>
differentiate between the log lines what zone it is about.<br>
<br>
So how should we solve this?<br>
- Maybe prepend zone to all log lines?<br>
</div>
</blockquote>
<div><br>
</div>
<div>+1. Simpler, doesn't reduce what is logged compared to
current behaviour </div>
<div>and can be post-processed easily if needed. </div>
<br>
</div>
</blockquote>
<br>
+1 Does this decision effect the enforcer-NG also? Do we want it to
be consistent?<br>
<br>
<blockquote
cite="mid:B59D54B7-7066-4CAB-9F88-2BF5248B7E48@sinodun.com"
type="cite">
<div>
<blockquote type="cite">
<div>- Remove most log lines while working and just return one
line per<br>
zone when finished successful or with error?<br>
- ?<br>
<br>
2. Enabling of multithreaded Enforcer<br>
<br>
The branch I have set up have a configuration option<br>
(--enable-enforcer-workers) to enable multithreaded Enforcer
at<br>
compile time.<br>
<br>
Is this the right approach or do we want this always
compiled and<br>
controlled by conf.xml ?<br>
</div>
</blockquote>
<div><br>
</div>
<div>I vote for conf.xml to make testing/roll-back easier (with
a default of disabled). </div>
<br>
</div>
</blockquote>
+1; although leave the compile flag in, in case folk want to build
without it?<br>
<br>
It also means that package maintainers will not need to build two
versions (or decide on one or the other)<br>
Are we going to make the "enforcer workers" tag mandatory? I vote
for optional and if it doesn't exist then workers == 1.<br>
<br>
Sion<br>
<br>
</body>
</html>