<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; "><div><div><div>Hi,</div><div><br></div><div>Patrik reported this problem today and its very easy to replicate in 1.3.2, just change the $TTL and issue a resign of the zone. Since there is no RDATA change the TTL does not get changed in the signed zone.</div><div><br></div><div>This is because util_dnssec_rrs_compare() uses ldns_rr_compare_wire() and that only checks for changes in RDATA.</div><div><br></div><div>Before I commit this fix that I've tested, I wanted to check if this can break anything else?</div><div><br></div><div>I can't see if this is a problem in trunk since it seems that most of the rr/rrset code has been changed.</div><div><br></div><div><div>/Jerry</div></div></div></div><div><br></div><div><div>Index: branches/OpenDNSSEC-1.3/signer/src/signer/rrset.c</div><div>===================================================================</div><div>--- branches/OpenDNSSEC-1.3/signer/src/signer/rrset.c<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 5654)</div><div>+++ branches/OpenDNSSEC-1.3/signer/src/signer/rrset.c<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div>@@ -474,6 +474,9 @@</div><div> </div><div> current = current->next;</div><div> } else { /* equal RRs */</div><div>+ <span class="Apple-tab-span" style="white-space:pre"> </span>/* TTL is not compared in util_dnssec_rrs_compare() so we copy it */</div><div>+ <span class="Apple-tab-span" style="white-space:pre"> </span>ldns_rr_set_ttl(current->rr, ldns_rr_ttl(pending->rr));</div><div>+</div><div> /* remove pending RR */</div><div> if (!prev) {</div><div> rrset->add = pending->next;</div></div><div><br></div></body></html>